fix: Address ai reviewer comments for delegation#6675
Open
yinyiqian1 wants to merge 3 commits intoXRPLF:developfrom
Open
fix: Address ai reviewer comments for delegation#6675yinyiqian1 wants to merge 3 commits intoXRPLF:developfrom
yinyiqian1 wants to merge 3 commits intoXRPLF:developfrom
Conversation
13 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6675 +/- ##
=========================================
- Coverage 81.5% 81.5% -0.0%
=========================================
Files 998 998
Lines 74456 74459 +3
Branches 7578 7558 -20
=========================================
+ Hits 60648 60649 +1
- Misses 13808 13810 +2
🚀 New features to boost your workflow:
|
shawnxie999
approved these changes
Apr 1, 2026
mvadari
reviewed
Apr 2, 2026
| // reclaimed after those networks reset. | ||
| // DEPRECATED: tecNO_DELEGATE_PERMISSION is reserved for backward | ||
| // compatibility with historical data on non-prod networks only. | ||
| // TODO(deprecation): Remove this entry and reclaim value 198 once all |
Collaborator
There was a problem hiding this comment.
Hasn't this TODO blocker happened already?
mvadari
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address AI review comments for #5825
High Level Overview of Change
Context of Change
API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)