Do not cache realm lookup failure for transient LDAP connection issues#301
Open
pavelhoral wants to merge 1 commit into
Open
Do not cache realm lookup failure for transient LDAP connection issues#301pavelhoral wants to merge 1 commit into
pavelhoral wants to merge 1 commit into
Conversation
pavelhoral
force-pushed
the
fix-realm-lookup
branch
from
775857e to
81f451c
Compare
Member
Author
|
My change only fixes when the connection can not be established, not when the connection gets dropped. I think this PR is good enough fix to get merged. Fixing the data layer would mean much bigger change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the config store is down during realm lookup, the failed lookup attempt gets cached and is never retried (unless the configuration changes). This PR introduces new SMS exception that allows for the code to distinguish when the underlying exception is not related to the request itself.
Btw. I thought about fixing this in a different way -> firing config-changed event when the persistent search is established with the config store, which will force
CachingRealmLookupto drop cached responses, but it felt a bit more complex with much more potential side effects.