fix: ensure execution stops after redirects #786
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR ensures that code execution stops after calling
wp_safe_redirect()in the two-factor authentication validation functions. Withoutexit(), PHP continues executing code after sending redirect headers, which could lead to security vulnerabilities or unintended behavior.Why?
This follows WordPress best practices and aligns with the existing function documentation that states "wp_safe_redirect() does not exit automatically, and should almost always be followed by a call to
exit;."How?
Add
exit()after calls towp_safe_redirect().Testing Instructions
N/A :-(
Screenshots or screencast
N/A
Changelog Entry