fix: make GitHub release depend on successful crate publish#43
Merged
mickvandijke merged 1 commit intomainfrom Mar 25, 2026
Merged
fix: make GitHub release depend on successful crate publish#43mickvandijke merged 1 commit intomainfrom
mickvandijke merged 1 commit intomainfrom
Conversation
The release job previously only depended on validate and sign, meaning a GitHub release could be created even if crate publishing failed. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the release workflow so creating the GitHub Release is gated on a successful crates.io publish, preventing “release artifacts published on GitHub but crate publish failed” situations.
Changes:
- Add
publish-crateto thereleasejob’sneedssoreleaseonly runs if crate publishing succeeds.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mickvandijke
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publish-crateto thereleasejob'sneedslist so a GitHub release is only created if crate publishing succeedsTest plan
🤖 Generated with Claude Code