You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Oct 25, 2022. It is now read-only.
I have applied the latest UI changes made in schema.md d8291be , to the schemaexamples/DCOI_StrategicPlans_fy2016Schema.json and saved it as a new schemaexamples/DCOI_StrategicPlans_fy2017Schema.json , changed schema version and title to fy2017.
List of changes:
Added DCOI_StrategicPlans_fy2017Schema.json to schemaexamples/
Changed link "DCOI Strategic Plan JSON Schema" to the latest fy2017 schema file.
Removed redundant " schema" word from the end of every field title.
@alex-perfilov-reisys
Thanks, Alex.
I think Sarah A asked me not to change the file name in the past because of versioning concerns. Can you triple check that all references to the schema have been updated in the Java tool? Thank you!
@BaconMichelle , I'm not sure which Java tool should I check. If you meant JSON Conversion Tool, which is written in JavaScript, then it does not have any references to the schema. It uses a local copy instead.
Also, I did not remove DCOI_StrategicPlans_fy2016Schema.json from repo. I've added a new fy2017 schema in same folder instead.
@alex-perfilov-reisys
Gotcha. Understood that nothing has been removed. Ideally, if I made a change to the schema file without renaming it, the tool would automatically update. Is that possible? Or no...
@BaconMichelle , that might be doable. But it also has some sample data which should also be in-sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have applied the latest UI changes made in schema.md d8291be , to the
schemaexamples/DCOI_StrategicPlans_fy2016Schema.jsonand saved it as a newschemaexamples/DCOI_StrategicPlans_fy2017Schema.json, changed schema version and title tofy2017.List of changes:
DCOI_StrategicPlans_fy2017Schema.jsontoschemaexamples/DCOI Strategic Plan JSON Schema" to the latest fy2017 schema file.schema" word from the end of every field title.I'm planning to use same schema to update https://datacenters.cio.gov/json-conversion-tool/