Skip to content

revert(accounts): restore inline account filters (#7853) - #8120

Merged
Wei-Shaw merged 1 commit into
mainfrom
revert/inline-account-filters
Oct 15, 2026
Merged

Wei-Shaw merged 1 commit into
mainfrom
revert/inline-account-filters

Conversation

@Wei-Shaw

Copy link
Copy Markdown
Owner

Summary

Reverts #7853 (commit 679a718). That PR moved the 类型 / 隐私 / 分组 filters on /admin/accounts into a collapsed "更多筛选" panel. This brings back the inline layout, where all five filters sit next to the search box, and fixes a few layout problems the old layout had.

Changes

Revert of #7853

  • Moves type / privacy / group back from the collapsed panel into the main filter bar.
  • Deletes AccountTableFilters.spec.ts. It only tested the collapse panel.
  • Removes the moreFilters / moreFiltersActive i18n keys (en, zh).
  • Removes the lg:w-auto lg:flex-1 class that feat(accounts): compact account search and filters #7853 added in AccountsView.vue.

Layout fixes (AccountTableFilters.vue)

  • Privacy select widened to w-48, so "全部Privacy状态" / "All Privacy States" is no longer cut off.
  • Search input narrowed from w-64 to w-52, so all six controls fit on one row at 1440px. Before, the group select wrapped onto its own row.
  • Below sm, the filters use a two-column grid that fills the width: search and group take a full row, the other four pair up. This replaces fixed-width selects that left a ragged right edge.

Verification

  • Screenshots against a local backend at 390 / 768 / 1280 / 1440 / 1920px, in zh and en:
  • vue-tsc: 0 errors.
  • eslint on the changed component: passes.

Revert 679a718 ("feat(accounts): compact account search and filters"),
which moved the type / privacy / group filters behind a collapsed
"More filters" panel on /admin/accounts.

Polish on top of the revert:
- Widen the privacy select (w-48) so "全部Privacy状态" / "All Privacy States"
  no longer truncates.
- Narrow the search input to w-52 so all six controls fit on one row at 1440px.
- Below sm, lay the filters out as a two-column grid that fills the width
  instead of fixed-width selects with a ragged edge.
@Wei-Shaw
Wei-Shaw merged commit 1b2243a into main Oct 15, 2026
16 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant