Skip to content

Keep a paused issue.md edit through a late update - #257

Merged
MHohlios merged 1 commit into
mainfrom
wiffletree/keep-a-paused-issue-md-edit-through-a-late-updat
Nov 2, 2026
Merged

MHohlios merged 1 commit into
mainfrom
wiffletree/keep-a-paused-issue-md-edit-through-a-late-updat

Conversation

@MHohlios

@MHohlios MHohlios commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

A Mac on an older release that pulls a teammate's move writes GitHub's moved files into the Space's folder but keeps its paused edit at the old root path. After it updates, the move step skipped any root file whose folder path already existed, so the edit stayed at the root where nothing reads it, and the next pass cleared the pause. The edit was lost.

folder::move_files now lets a file left at the root replace the folder's copy, unless the root copy is a forwarding stub. The copy it replaces is GitHub's committed content, so nothing is lost: the next pass pauses the edit again at its moved path (OutsideWiffletree) and shows it in the Inbox, with GitHub's version as theirs.

A follow-up to #235.

Tests: a_pause_an_older_host_kept_through_a_teammates_move_follows_its_file_after_the_update. An older-layout clone with a paused issue.md edit pulls a move and then runs the new release's first pass; the edit is still paused at its moved path. It fails without the fix (no pause left).

Follow-ups

  • An unchanged old root copy also replaces the folder copy, so a teammate's later folder edit can show on this Mac as a pause its human never made; nothing is lost, as GitHub keeps the newer copy (crates/workspace-host/src/folder.rs:330).

Reviewed with Wiffletree: 1 full review and 0 re-checks, 1 round (Tests, Claude, Style)

…move

An older release that pulled a teammate's move wrote GitHub's files into
the folder and kept its paused issue.md edit at the old path. Adopting the
move then left that edit behind and dropped its pause. A file left at the
root now replaces the folder's copy unless it is a stub, so the next pass
pauses the edit again at its moved path.
@MHohlios
MHohlios merged commit 5cf1896 into main Nov 2, 2026
9 checks passed
@MHohlios
MHohlios deleted the wiffletree/keep-a-paused-issue-md-edit-through-a-late-updat branch November 2, 2026 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant