Repository navigation
Map: Forget room action on the map panel - #28
Merged
MHohlios merged 2 commits intoNov 3, 2026
Merged
Conversation
added 2 commits
November 2, 2026 22:37
A selected room gets a Forget room button beside Pick to join. It asks once, inline, then sends MapEdit::Forget, which the session runs through LiveMap::forget. The pill says which room went and that walking in maps it again.
The macOS accessibility check now finds Forget room, the question's Cancel and Forget, and follows focus into the question and back. The Forget test reads the pill's own text, and the pill's and the room row's comments say what they now hold.
MHohlios
deleted the
wiffletree/map-forget-room-action-on-the-map-panel
branch
November 3, 2026 11:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A wrongly mapped room had no way out: walking back in didn't fix it, and nothing in the app could remove it. The core already had a tested
LiveMap::forget, but nothing called it.What changed
MapEdit::Forget { room }(session.rs), handled insession/engine.rsedit_mapbyself.map.forget(&[room]). The next settle saves and publishes it like any map change.map_view/forget.rs. With a room selected on the map panel, a "Forget room" button sits beside "Pick to join". It's shown even when picking isn't possible.JoinNote::Forgotvariant).Tests
rules::a_forgotten_room_leaves_the_map_and_stays_gone_next_session.map_view::forget::tests::cancel_keeps_the_room_and_forget_tells_the_session,escape_backs_out_of_the_question,selecting_another_room_backs_out_of_the_question.cargo fmt --check,cargo clippy --workspace --all-targetsandcargo test --workspacepass.mudling-desktop --synthetic --ax-checkpasses all 79 checks.Reviewed with Wiffletree: 1 full review and 1 re-check, 2 rounds (Tests, Claude, Style)