VCST-5143: Improve performance#496
Open
OlegoO wants to merge 3 commits into
Open
Conversation
feat: Improve performance
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
feat: Improve performance
References
QA-test:
Jira-link:
https://virtocommerce.atlassian.net/browse/VCST-5143
Artifact URL:
https://vc3prerelease.blob.core.windows.net/packages/VirtoCommerce.Orders_3.1009.0-pr-496-b15b.zip
Note
Low Risk
Single-line guard change with identical semantics on an existing EF read path.
Overview
GetShipmentsByIdsAsyncnow checksresult.Length != 0instead ofresult.Any()when deciding whether to return the loaded shipment entities or an empty array. Behavior is unchanged; this avoids enumerating the array just to test emptiness and matches the same pattern already used inGetPaymentsByIdsAsyncandGetCustomerOrdersByIdsAsyncinOrderRepository.Reviewed by Cursor Bugbot for commit b15b1d0. Bugbot is set up for automated code reviews on this repo. Configure here.