Fix text components in signs not being rewritten in the 1.21.7→1.21.5 step#1173
Merged
kennytv merged 1 commit intoViaVersion:masterfrom Jan 10, 2026
Merged
Conversation
… step This was causing connection crashes for versions ≤1.21.4, since the 1.21.5.→1.21.4 step rewrites all text components as strings, and thus parses the NBT. Since custom click events (and dialogs) were not being filtered on signs in the 1.21.6→1.21.5 step (despite being correctly handled everywhere else since ViaVersion#1108), the latter step was failing to properly read the NBT structure and thus crashing the player's connection. The fix was done by lifting the sign logic in `BlockItemPacketRewriter1_21_5` and adapting it into `BlockItemPacketRewriter1_21_6`. All filtering is still delegated to the appropriate `ComponentRewriter`, so required code change was rather small. This commit is almost identical to my other fix related to sprites in the 1.21.9→1.21.7 step. See commit d273b06 (e3a4761) and PR ViaVersion#1147. Fixes ViaVersion#1172
florianreuth
approved these changes
Jan 8, 2026
Member
florianreuth
left a comment
florianreuth
left a comment
There was a problem hiding this comment.
Yeah probably time we move all of this into the general rewriter class, thank you
kennytv
approved these changes
Jan 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was causing connection crashes for versions ≤1.21.4, since the 1.21.5.→1.21.4 step rewrites all text components as strings, and thus parses the NBT.
Since custom click events (and dialogs) were not being filtered on signs in the 1.21.6→1.21.5 step (despite being correctly handled everywhere else since #1108), the latter step was failing to properly read the NBT structure and thus crashing the player's connection.
The fix was done by lifting the sign logic in
BlockItemPacketRewriter1_21_5and adapting it intoBlockItemPacketRewriter1_21_6. All filtering is still delegated to the appropriateComponentRewriter, so required code change was rather small.This commit is almost identical to my other fix related to sprites in the 1.21.9→1.21.7 step. See commit d273b06 (e3a4761) and PR #1147.
Fixes #1172