feat(governance): add event emission coverage and validation tests (#…#601
Merged
Merged
Conversation
…era3289#482) - Add dedicated proposal_executed and proposal_cancelled event functions in events.rs, replacing the incorrect reuse of proposal_finalised for execute() and cancel() actions - Wire new events in lib.rs execute() and cancel() - Add 5 event-validation tests covering all state-changing actions: test_event_proposal_created, test_event_vote_cast, test_event_proposal_finalised, test_event_proposal_executed, test_event_proposal_cancelled - Add docs/events.md with full event schema, off-chain indexer integration guide, and schema stability policy Closes Vera3289#482
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #482 Fixes a bug where execute() and cancel() emitted the generic proposal_finalised event, making
them indistinguishable from a finalisation on the event stream. Adds dedicated events for every
state transition and validates all event payloads in tests.
Changes
events.rs
lib.rs
test.rs
docs/events.md (new)
Acceptance Criteria
┌───────────┬────────┐
│ Criterion │ Status │
├───────────────────────────────────────────────────────────────────────┼────────┤
│ Proposal creation, voting, finalisation, and cancellation emit events │ ✅ │
├───────────────────────────────────────────────────────────────────────┼────────┤
│ Event contents are validated in tests │ ✅ │
├───────────────────────────────────────────────────────────────────────┼───────────────────┤
│ Off-chain indexing needs are documented │ ✅ docs/events.md │
├───────────────────────────────────────────────────────────────────────┼───────────────────┤
│ No silent state changes without events │ ✅ │
└───────────────────────────────────────────────────────────────────────┴────────────────