feat: add explicit admin role separation (#475)#598
Open
Magada06 wants to merge 1 commit into
Open
Conversation
- Governance: two-step transfer_admin/accept_admin with events - Governance: proposer allowlist (add_proposer, remove_proposer) - Governance: create_proposal restricted to allowlisted proposers - Token: two-step transfer_admin/accept_admin with events - Token: emit mint/transfer/burn events (fixes pre-existing gap) - Tests: 23 governance + 15 token all passing - Fix pre-existing broken event comparison tests in token Closes Vera3289#475
|
@Magada06 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #475 Enforces clear role boundaries between admin, proposer, and voter across both contracts.
Admin-only functions now reject unauthorized callers, admin ownership transfer follows a safe
two-step pattern, and all role changes emit on-chain events for auditability.
Changes
Governance contract
Token contract
Tests
38 tests passing (23 governance, 15 token), including:
Acceptance Criteria
┌───────────┬────────┐
│ Criterion │ Status │
├────────────────────────────────────────────────────┼────────┤
│ Contracts distinguish admin, proposer, voter roles │ ✅ │
├────────────────────────────────────────────────────┼────────┤
│ Admin-only functions reject non-admin callers │ ✅ │
├────────────────────────────────────────────────────┼──────────────────────┤
│ Role transfer flow is safe and auditable │ ✅ two-step + events │
├────────────────────────────────────────────────────┼─────────────────────────┤
│ Tests cover unauthorized access │ ✅ 9 new negative tests │
└────────────────────────────────────────────────────┴─────────────────────────┘