steamcompmgr: Reset focusWindow after entering iconic state.#2237
Open
zzhiyi wants to merge 1 commit into
Open
steamcompmgr: Reset focusWindow after entering iconic state.#2237zzhiyi wants to merge 1 commit into
zzhiyi wants to merge 1 commit into
Conversation
After "0a09639d steamcompmgr: Accept any requested iconic state change.", a focus change is required to change the state of a window to ICCCM_NORMAL_STATE. However, ctx->focus.focusWindow is not changed. So, in DetermineAndApplyFocus(), the "if ( prevFocusWindow != ctx->focus.focusWindow )" fails, thus the window is not restored to ICCCM_NORMAL_STATE when expected. Fix RPGMaker Engine games that freeze after minimization.
Collaborator
|
This isn't working as advertised. Tested with a couple of games ("Labyrinth Flowers" and "Obscurite Magie 3: The Divine Stones") that when run with Proton 10 are windowed and allow minimizing, what I'm observing is that when I first click to minimize the window, rendering doesn't freeze, but the window isn't minimized either. If I click again on the minimize button, rendering freezes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After "0a09639d steamcompmgr: Accept any requested iconic state change.", a focus change is required to change the state of a window to ICCCM_NORMAL_STATE. However, ctx->focus.focusWindow is not changed. So, in DetermineAndApplyFocus(), the "if ( prevFocusWindow != ctx->focus.focusWindow )" fails, thus the window is not restored to ICCCM_NORMAL_STATE when expected.
Fix RPGMaker Engine games that freeze after minimization.