rendervulkan: do not detach, and stop the pipeline compilation thread at exit#2234
Open
oSoMoN wants to merge 1 commit into
Open
rendervulkan: do not detach, and stop the pipeline compilation thread at exit#2234oSoMoN wants to merge 1 commit into
oSoMoN wants to merge 1 commit into
Conversation
… at exit If the selected backend fails to initialize, gamescope exits early. If main() returns while the pipeline thread is busy compiling shaders, it might try to emplace a pipeline into the map of a deleted object (the static g_device), causing a crash. This change breaks out of the shader compilation loop at exit, thus saving unnecessary work, and ensuring gamescope exits cleanly.
|
I've tested this locally and indeed it prevents gamescope from crashing in a headless setup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the selected backend fails to initialize, gamescope exits early. If main() returns while the pipeline thread is busy compiling shaders, it might try to emplace a pipeline into the map of a deleted object (the static g_device), causing a crash.
This change breaks out of the shader compilation loop at exit, thus saving unnecessary work, and ensuring gamescope exits cleanly.