(Duplicated)wayland: do not require sRGB transfer support for HDR#2227
Closed
drbermejor wants to merge 1 commit into
Closed
(Duplicated)wayland: do not require sRGB transfer support for HDR#2227drbermejor wants to merge 1 commit into
drbermejor wants to merge 1 commit into
Conversation
|
we have #2222 which looks to be the exact same fix |
Author
|
Closing this as duplicate of #2222. I initially opened it because applying #2222 locally did not solve the issue in my environment, but after comparing the final diff both PRs are equivalent. The useful part here is the runtime validation: this change exposes HDR correctly on KDE Plasma/KWin 6.7 with gamescope under CachyOS/RX 9070 XT. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This relaxes the Wayland color-management capability check by no longer requiring
WP_COLOR_MANAGER_V1_TRANSFER_FUNCTION_SRGBbefore exposing HDR support to clients.Motivation
On KDE Plasma/KWin 6.7, nested gamescope sees HDR enabled on the host compositor, but refuses to expose HDR formats to clients because the sRGB transfer function is not advertised in the way gamescope currently expects.
Before this change, gamescope reports:
After this change, on the same system, gamescope reports:
Tested Setup
System:
Game/application tested:
Launch options used:
Also tested with the same gamescope launch path using both:
With both Proton builds, after this patch gamescope exposes HDR successfully:
The game log also keeps HDR enabled instead of reporting unsupported HDR output:
Before this patch, the same game and launch options reached gamescope, but HDR was not exposed to the client:
Related
Refs: #2221