Repository navigation
Conversation
The browser tests run as ExUnit tests in e2e_pw/ (MIX_ENV=e2e mix test), against the server of test/e2e/server.exs started in the same VM. The suite lives outside test/ so that a plain mix test, including on Elixir 1.15, does not load it. The e2e CI job runs on Elixir 1.19, as playwright_ex needs 1.18 or later.
Delete the Playwright Test specs, config and helpers, and the @playwright/test dependency and npm scripts. mix e2e.test builds the assets and runs the ExUnit suite; docs updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tl;dr I'm preparing the next playwright_ex major version and ported your test suite to validate the RC.
Please feel free to close this PR without comment if you're not interested 🙂.
What changed?
Why make these changes?
Further notes