Draft
Conversation
mkornaukhov
suggested changes
Mar 18, 2025
mkornaukhov
left a comment
mkornaukhov
left a comment
There was a problem hiding this comment.
Could you write an description or explanation?
Comment on lines
+125
to
+126
| cxxCmdLine = append(cxxCmdLine, cxxArgs...) | ||
| cxxCmdLine = append(cxxCmdLine, "-Wp,-v", "-x", "c++", "/dev/null", "-fsyntax-only") |
Contributor
Author
There was a problem hiding this comment.
And for what and why?
| objOutFile string // output file as specified in cmd line (.o for compilation, .gch/.pch for pch generation) | ||
| cxxName string // g++ / clang / etc. | ||
| cxxArgs []string // args like -Wall, -fpch-preprocess and many more, except: | ||
| cxxArgsIncludes []string // TODO |
There was a problem hiding this comment.
TODO mark is present but not explained
troy4eg
reviewed
Apr 22, 2025
| cxxArgsIncludes: make([]string, 0, 1), | ||
| cxxIDirs: MakeIncludeDirs(), | ||
| summary: MakeInvocationSummary(), | ||
| includesCache: nil, // TODO |
troy4eg
reviewed
Apr 22, 2025
internal/client/invocation.go
Outdated
| invocation.cxxArgs = append(invocation.cxxArgs, "-Xclang", xArg) | ||
| i++ | ||
| continue | ||
| } else if strings.HasPrefix(arg, "-stdlib=") { |
Contributor
There was a problem hiding this comment.
from clang docs: -stdlib=<arg>, --stdlib=<arg>, --stdlib <arg>
from gcc docs: -stdlib=libstdc++,libc++
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.