Skip to content

Final PoC.arith tests converted to OSVVM#34

Merged
Paebbels merged 4 commits intoVHDL:devfrom
gmartina:convert-tb-to-osvvm3
Nov 30, 2025
Merged

Final PoC.arith tests converted to OSVVM#34
Paebbels merged 4 commits intoVHDL:devfrom
gmartina:convert-tb-to-osvvm3

Conversation

@gmartina
Copy link

@gmartina gmartina commented Nov 30, 2025

New Features

  • New tests for the rest of Arith components:
tb/arith/trng
tb/arith/sqrt
tb/arith/shifter_barrel
tb/arith/same
tb/arith/counter_ring
tb/arith/counter_gray
tb/arith/counter_free
tb/arith/cca
tb/arith/carrychain_inc

Related Issues and Pull-Requests

Paebbels
Paebbels requested changes Nov 30, 2025
View reviewed changes
Copy link
Member

@Paebbels Paebbels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also provide a commit which deletes the original testcases. All the proposed cases have been translated and accepted when this PR gets merged.

No technical finding, just about headers, authors and copyright notes :)

tb/arith/carrychain_inc/RunAllTests.pro
Comment on lines 1 to 4
# =============================================================================
# Authors:
# Gustavo Martin
# =============================================================================
Copy link
Member

@Paebbels Paebbels Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as my finding in #33, please use a full file header including license part in new *.pro files.

tb/arith/carrychain_inc/arith_carrychain_inc_Simple.vhdl
-- vim: tabstop=2:shiftwidth=2:noexpandtab
-- kate: tab-width 2; replace-tabs off; indent-width 2;
-- =============================================================================
-- Authors: Gustavo Martin
Copy link
Member

@Paebbels Paebbels Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add the original author.

Copy link
Author

@gmartina gmartina Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests of this PR were created by me, not ported.
I could not find tests for this components, that is why I created them.

Copy link
Member

@Paebbels Paebbels Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry. Than all is correct.

Copy link
Member

@Paebbels Paebbels Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a Gitter or Matrix user? We could clarify questions maybe easier and quicker in a Gitter channel. Gitter is a chat parallel to GitHub repositories.

Copy link
Author

@gmartina gmartina Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont have. I will create an account.

Copy link
Member

@Paebbels Paebbels Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, we (me and @stefanunrein) have signal. We could create a PoC group or so.

tb/arith/carrychain_inc/arith_carrychain_inc_Simple.vhdl
--
-- License:
-- =============================================================================
-- Copyright 2025-2025 The PoC-Library Authors
Copy link
Member

@Paebbels Paebbels Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the original copyright underneath.

tb/arith/cca/arith_cca_Simple.vhdl
-- vim: tabstop=2:shiftwidth=2:noexpandtab
-- kate: tab-width 2; replace-tabs off; indent-width 2;
-- =============================================================================
-- Authors: Gustavo Martin
Copy link
Member

@Paebbels Paebbels Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please preserve original author.

tb/arith/cca/arith_cca_Simple.vhdl
--
-- License:
-- =============================================================================
-- Copyright 2025-2025 The PoC-Library Authors
Copy link
Member

@Paebbels Paebbels Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please preserve original copyright underneath.

tb/arith/sqrt/arith_sqrt_Simple.vhdl
--
-- License:
-- =============================================================================
-- Copyright 2025-2025 The PoC-Library Authors
Copy link
Member

@Paebbels Paebbels Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please preserve the original copyright underneath.

tb/arith/shifter_barrel/arith_shifter_barrel_Simple.vhdl
--
-- License:
-- =============================================================================
-- Copyright 2025-2025 The PoC-Library Authors
Copy link
Member

@Paebbels Paebbels Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please preserve the original copyright underneath.

tb/arith/same/arith_same_Simple.vhdl
--
-- License:
-- =============================================================================
-- Copyright 2025-2025 The PoC-Library Authors
Copy link
Member

@Paebbels Paebbels Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please preserve the original copyright underneath.

tb/arith/counter_ring/arith_counter_ring_Simple.vhdl
--
-- License:
-- =============================================================================
-- Copyright 2025-2025 The PoC-Library Authors
Copy link
Member

@Paebbels Paebbels Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please preserve the original copyright underneath.

tb/arith/counter_gray/arith_counter_gray_Simple.vhdl
--
-- License:
-- =============================================================================
-- Copyright 2025-2025 The PoC-Library Authors
Copy link
Member

@Paebbels Paebbels Nov 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please preserve the original copyright underneath.

@Paebbels Paebbels added PoC.arith.* Arithmetic components. Testbench Testbench related. labels Nov 30, 2025
@Paebbels Paebbels mentioned this pull request Nov 30, 2025
Open
@Paebbels Paebbels changed the title New tests for the rest of Arith components Final PoC.arith tests converted to OSVVM Nov 30, 2025
@Paebbels Paebbels mentioned this pull request Nov 30, 2025
Draft
@gmartina gmartina marked this pull request as draft November 30, 2025 18:42
@gmartina gmartina marked this pull request as ready for review November 30, 2025 19:07
@gmartina gmartina requested a review from Paebbels November 30, 2025 19:07
@Paebbels Paebbels merged commit ef8b83e into VHDL:dev Nov 30, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Paebbels Paebbels Awaiting requested review from Paebbels

Assignees

@gmartina gmartina

Labels

PoC.arith.* Arithmetic components. Testbench Testbench related.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gmartina @Paebbels