fix(#911): apply CEI pattern and ReentrancyGuard to withdraw and claimRewards#7304
Closed
BWM0223 wants to merge 3 commits into
Closed
fix(#911): apply CEI pattern and ReentrancyGuard to withdraw and claimRewards#7304BWM0223 wants to merge 3 commits into
BWM0223 wants to merge 3 commits into
Conversation
Author
|
Payment wallets: ETH/ERC-20: 0xeaCAb48a4bfA0CED0e668c166615927115655594 | SOL: C3MD2yfWYebB8FYXpq6ooqzU5GCQB1bDxbDhQf1JfiCW | BTC: bc1qtmlgtvg7xgv0zry3ct90elp3y7d3ffdutk4e2f |
Contributor
|
Unfortunately the changes in this PR didn't fully resolve the issue. Please rework your solution and submit a new pull request. Make sure to review the acceptance criteria in the linked issue and verify all conditions are met before resubmitting. See CONTRIBUTING.md for guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #911. Moves state updates before external calls in withdraw and claimRewards. Adds nonReentrant modifier. Includes reentrancy attack test with malicious contract.