Skip to content

fix(backend): close Stellar Wave issues #2, #3, #105, #121#122

Merged
dzekojohn4 merged 1 commit into
UnityChainxx:mainfrom
Mai-Fura:fix/mai-fura-stellar-wave-7
Jul 25, 2026
Merged

fix(backend): close Stellar Wave issues #2, #3, #105, #121#122
dzekojohn4 merged 1 commit into
UnityChainxx:mainfrom
Mai-Fura:fix/mai-fura-stellar-wave-7

Conversation

@Mai-Fura

Copy link
Copy Markdown
Contributor

Summary\n\nResolves the four issues assigned to me in the Stellar Wave program.\n\n- #2backend/src/main.ts was a duplicate of app.module.ts. Replaced with a real NestFactory.create(AppModule) bootstrap that wires global /api prefix (frontend already calls /api/login, /api/register, etc.), global ValidationPipe, CORS from appConfig, and Swagger UI at canonical /docs.\n- #3backend/src/app.module.ts had two concatenated sets of imports in conflicting quote styles. Collapsed into a single @Module({}) block with consistent single-quote imports. Kept the same 20 modules that were wired in the original (Auth/UserInventory/PuzzleCategory/Rewards were declared but never wired in the @Module array; intentionally left dormant in this PR).\n- #105GET /api/users/:userId/history now accepts ?page= and ?limit= query parameters and returns { data, meta: { total, page, limit, totalPages } }. Defaults: page=1, limit=20; max limit=100. Deterministic sort (lastSolved DESC, puzzleId ASC). Existing getUserPuzzleStats left intact for back-compat.\n- #121 — Added MIT LICENSE file at the repo root to match what README.md references. Also synced backend/package.json \"license": \"MIT" (was previously \"UNLICENSED").\n\n## Out of scope (separate follow-ups)\n\n- The repo has 38 pre-existing TypeScript errors in unrelated modules (session, streak, ethers, nanoid deps, jwt.guard/wallet.guard decorator misuse). They are not introduced by this PR and will block nest build on CI until a cleanup PR lands.\n- The four modules declared but not previously wired (AuthModule, UserInventoryModule, PuzzleCategoryModule, RewardsModule) can be opted-in by appending them to app.module.ts in a follow-up to register their controllers.\n\nCloses #2\nCloses #3\nCloses #105\nCloses #121

, UnityChainxx#105, UnityChainxx#121

* UnityChainxx#2: backend/src/main.ts is now a real NestJS bootstrap (NestFactory.create,
  global /api prefix excluding /docs, ValidationPipe, Swagger at /docs, CORS
  from appConfig, port from PORT env) instead of a duplicated copy of
  app.module.ts.
* UnityChainxx#3: backend/src/app.module.ts collapsed into a single @module block with
  consistent single-quote imports. Only the 20 modules from the original
  @module imports array are wired in (previously dormant imports for
  Auth/UserInventory/PuzzleCategory/Rewards intentionally left to a
  follow-up).
* UnityChainxx#105: GET /api/users/:userId/history now accepts ?page=&limit= query
  params and returns { data, meta: { total, page, limit, totalPages } }.
  Defaults page=1, limit=20, max=100. Existing getUserPuzzleStats left
  intact for back-compat. Deterministic sort by lastSolved DESC, puzzleId.
* UnityChainxx#121: Added MIT LICENSE file at repo root, matching the README. Also
  aligned backend/package.json license field to MIT.

Closes UnityChainxx#2
Closes UnityChainxx#3
Closes UnityChainxx#105
Closes UnityChainxx#121
@Mai-Fura
Mai-Fura force-pushed the fix/mai-fura-stellar-wave-7 branch from 6f5c431 to a1c5c37 Compare July 24, 2026 10:08
@drips-wave

drips-wave Bot commented Jul 24, 2026

Copy link
Copy Markdown

@Mai-Fura Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@dzekojohn4 dzekojohn4 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dzekojohn4
dzekojohn4 merged commit ef28721 into UnityChainxx:main Jul 25, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants