fix(backend): close Stellar Wave issues #2, #3, #105, #121#122
Merged
dzekojohn4 merged 1 commit intoJul 25, 2026
Merged
Conversation
, UnityChainxx#105, UnityChainxx#121 * UnityChainxx#2: backend/src/main.ts is now a real NestJS bootstrap (NestFactory.create, global /api prefix excluding /docs, ValidationPipe, Swagger at /docs, CORS from appConfig, port from PORT env) instead of a duplicated copy of app.module.ts. * UnityChainxx#3: backend/src/app.module.ts collapsed into a single @module block with consistent single-quote imports. Only the 20 modules from the original @module imports array are wired in (previously dormant imports for Auth/UserInventory/PuzzleCategory/Rewards intentionally left to a follow-up). * UnityChainxx#105: GET /api/users/:userId/history now accepts ?page=&limit= query params and returns { data, meta: { total, page, limit, totalPages } }. Defaults page=1, limit=20, max=100. Existing getUserPuzzleStats left intact for back-compat. Deterministic sort by lastSolved DESC, puzzleId. * UnityChainxx#121: Added MIT LICENSE file at repo root, matching the README. Also aligned backend/package.json license field to MIT. Closes UnityChainxx#2 Closes UnityChainxx#3 Closes UnityChainxx#105 Closes UnityChainxx#121
Mai-Fura
force-pushed
the
fix/mai-fura-stellar-wave-7
branch
from
July 24, 2026 10:08
6f5c431 to
a1c5c37
Compare
|
@Mai-Fura Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\nResolves the four issues assigned to me in the Stellar Wave program.\n\n- #2 —
backend/src/main.tswas a duplicate ofapp.module.ts. Replaced with a realNestFactory.create(AppModule)bootstrap that wires global/apiprefix (frontend already calls/api/login,/api/register, etc.), globalValidationPipe, CORS fromappConfig, and Swagger UI at canonical/docs.\n- #3 —backend/src/app.module.tshad two concatenated sets of imports in conflicting quote styles. Collapsed into a single@Module({})block with consistent single-quote imports. Kept the same 20 modules that were wired in the original (Auth/UserInventory/PuzzleCategory/Rewards were declared but never wired in the@Modulearray; intentionally left dormant in this PR).\n- #105 —GET /api/users/:userId/historynow accepts?page=and?limit=query parameters and returns{ data, meta: { total, page, limit, totalPages } }. Defaults: page=1, limit=20; max limit=100. Deterministic sort (lastSolved DESC, puzzleId ASC). ExistinggetUserPuzzleStatsleft intact for back-compat.\n- #121 — Added MITLICENSEfile at the repo root to match whatREADME.mdreferences. Also syncedbackend/package.json\"license": \"MIT"(was previously\"UNLICENSED").\n\n## Out of scope (separate follow-ups)\n\n- The repo has 38 pre-existing TypeScript errors in unrelated modules (session,streak,ethers,nanoiddeps,jwt.guard/wallet.guarddecorator misuse). They are not introduced by this PR and will blocknest buildon CI until a cleanup PR lands.\n- The four modules declared but not previously wired (AuthModule,UserInventoryModule,PuzzleCategoryModule,RewardsModule) can be opted-in by appending them toapp.module.tsin a follow-up to register their controllers.\n\nCloses #2\nCloses #3\nCloses #105\nCloses #121