Skip to content

Conversation

@NoelStephensUnity
Copy link
Member

@NoelStephensUnity NoelStephensUnity commented Jan 26, 2026

WIP-TODO:

  • Depends upon internal PR-89134 to get merged.
  • Will adjust the conditional define to be a more precise 6000.4 & 6000.5 version range to assure previous versions still work.

Purpose of this PR

Making adjustments to the changes in FindObjectsByType. Funneling all find object related calls into a single static method in order to simplify the current, and any future, updates/changes to FindObjectsByType.

Jira ticket

MTT-14339

Changelog

  • Changed: Updating usage of deprecated FindObjectsByType(FindObjectsSortMode) and enum FindObjectSortMode.

Documentation

  • No documentation changes or additions were necessary.

Testing & QA (How your changes can be verified during release Playtest)

Functional Testing

Manual testing :

  • Manual testing done

Automated tests:

  • Covered by existing automated tests
  • Covered by new automated tests

Does the change require QA team to:

  • Review automated tests?
  • Execute manual tests?
  • Provide feedback about the PR?

If any boxes above are checked the QA team will be automatically added as a PR reviewer.

Backports

No back port required since this is specific to 6000.4 & 6000.5.

Funneling all find object related calls into a single static method in order to simplify the current, and any future, updates/changes to FindObjectsByType.
@NoelStephensUnity NoelStephensUnity requested review from a team and EmandM as code owners January 26, 2026 20:45
Making FindObjects internal.
Adjusted to explicit handling of the update within test project script to avoid having to make FindObjects public.
Adding [MethodImpl(MethodImplOptions.AggressiveInlining)] attribute to the T[] FindObjectsByType<T>() method.
Removing unused using directives.
Removing CR.
Copy link
Member

@EmandM EmandM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love love love this cleanup! :godmode:

NoelStephensUnity and others added 2 commits January 26, 2026 16:07
Co-authored-by: Emma <emma.mcmillan@unity3d.com>
Adding same condition define, NGO_FINDOBJECTS_NOSORTING, to the testproject.manualtests assembly define.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants