FIX: Mark InputSystemForUI.Editor assembly as Editor-only to fix Assembly Definition Validation failure#2454
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
💡 Harness Review
The assembly-definition change itself is straightforward, but the validation bookkeeping is still out of sync with it.
ValidationExceptions.json still exempts this exact Assembly Definition Validation failure for package version 1.20.0 (For editor assemblies, 'Editor' should be present... InputSystemForUI.Editor.asmdef). With that exemption left in place, the validation pipeline will keep ignoring the rule you are fixing here, so this PR does not actually prove the validation issue is gone and future regressions of the same check will stay masked for this release. Remove the stale exception in the same PR so validation starts enforcing the corrected asmdef again.
Reviewed commit 5a7dab75
🤖 Helpful? 👍/👎
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ran validation, this part failed so added its suggested fix
Testing status & QA
CI only
Overall Product Risks
Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.
Comments to reviewers
N/A
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.