Skip to content

FIX: Mark InputSystemForUI.Editor assembly as Editor-only to fix Assembly Definition Validation failure#2454

Merged
Pauliusd01 merged 1 commit into
developfrom
Fix-validation-issues
Jul 21, 2026
Merged

FIX: Mark InputSystemForUI.Editor assembly as Editor-only to fix Assembly Definition Validation failure#2454
Pauliusd01 merged 1 commit into
developfrom
Fix-validation-issues

Conversation

@Pauliusd01

Copy link
Copy Markdown
Collaborator

Description

Ran validation, this part failed so added its suggested fix

Testing status & QA

CI only

Overall Product Risks

Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.

  • Complexity: low
  • Halo Effect: low

Comments to reviewers

N/A

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@Pauliusd01
Pauliusd01 merged commit a555b29 into develop Jul 21, 2026
5 of 58 checks passed
@Pauliusd01
Pauliusd01 deleted the Fix-validation-issues branch July 21, 2026 09:49

@u-pr u-pr Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Harness Review

LGTM

The assembly-definition change itself is straightforward, but the validation bookkeeping is still out of sync with it.

P2

ValidationExceptions.json still exempts this exact Assembly Definition Validation failure for package version 1.20.0 (For editor assemblies, 'Editor' should be present... InputSystemForUI.Editor.asmdef). With that exemption left in place, the validation pipeline will keep ignoring the rule you are fixing here, so this PR does not actually prove the validation issue is gone and future regressions of the same check will stay masked for this release. Remove the stale exception in the same PR so validation starts enforcing the corrected asmdef again.

Reviewed commit 5a7dab75

🤖 Helpful? 👍/👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant