Skip to content

FIX: Restore sample materials broken by URP upgrade, fix pink probuilder materials in rolling ball scene#2451

Merged
Pauliusd01 merged 1 commit into
developfrom
Fix-TouchSamples-Materials
Jul 20, 2026
Merged

FIX: Restore sample materials broken by URP upgrade, fix pink probuilder materials in rolling ball scene#2451
Pauliusd01 merged 1 commit into
developfrom
Fix-TouchSamples-Materials

Conversation

@Pauliusd01

Copy link
Copy Markdown
Collaborator

Description

Some materials were broken after URP upgrade, dependency note was missing from readme and rolling ball scene had pink probuilder shaders for ages unrelated to the URP upgrade so might as well fix those. Note: the probuilder remnants still exist and this does not fix any of it just cleans up the ancient eyesore

Testing status & QA

Checked all scenes android and windows.

Overall Product Risks

Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.

  • Complexity: low
  • Halo Effect: low

Comments to reviewers

N/A

Checklist

Before review:

  • Changelog entry added.
    • Explains the change in Changed, Fixed, Added sections.
    • For API change contains an example snippet and/or migration example.
    • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
    • Jira port for the next release set as "Resolved".
  • Tests added/changed, if applicable.
    • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
    • Performance tests.
    • Integration tests.
  • Docs for new/changed API's.
    • Xmldoc cross references are set correctly.
    • Added explanation how the API works.
    • Usage code examples added.
    • The manual is updated, if needed.

During merge:

  • Commit message for squash-merge is prefixed with one of the list:
    • NEW: ___.
    • FIX: ___.
    • DOCS: ___.
    • CHANGE: ___.
    • RELEASE: 1.1.0-preview.3.

@u-pr u-pr Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Harness Review

Ship it

Documentation-only change appears consistent with the sample projects' current shader dependencies; I didn't find a concrete issue worth flagging.

Reviewed commit af9f51a8

🤖 Helpful? 👍/👎

@codecov-github-com

codecov-github-com Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

@@           Coverage Diff            @@
##           develop    #2451   +/-   ##
========================================
  Coverage    78.95%   78.95%           
========================================
  Files          767      767           
  Lines       140780   140780           
========================================
  Hits        111147   111147           
  Misses       29633    29633           
Flag Coverage Δ
inputsystem_Ubuntu_6000.0 5.31% <ø> (ø)
inputsystem_Ubuntu_6000.0_project 77.40% <ø> (+<0.01%) ⬆️
inputsystem_Ubuntu_6000.3 5.31% <ø> (ø)
inputsystem_Ubuntu_6000.5 5.30% <ø> (ø)
inputsystem_Ubuntu_6000.6 5.30% <ø> (ø)
inputsystem_Ubuntu_6000.6_project 77.46% <ø> (ø)
inputsystem_Ubuntu_6000.7 5.30% <ø> (ø)
inputsystem_Windows_6000.0 5.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

ℹ️ Need help interpreting these results?

@Pauliusd01 Pauliusd01 changed the title FIX: Restore demo sample materials broken by URP upgrade, fix pink materials in rolling ball scene FIX: Restore sample materials broken by URP upgrade, fix pink probuilder materials in rolling ball scene Jul 20, 2026
@Pauliusd01
Pauliusd01 merged commit ffbc4ca into develop Jul 20, 2026
35 of 112 checks passed
@Pauliusd01
Pauliusd01 deleted the Fix-TouchSamples-Materials branch July 20, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant