MecResponseApp: fix service discovery and port issues caused by latest refactorings#295
Merged
avarga merged 3 commits intoUnipisa:masterfrom Mar 6, 2026
Merged
Conversation
In the recent refactoring, the localUePort was removed from the MecBaseApp. Since it is required in the MecResponseApp, this commit adds it there. Note that this problem was not detected by the fingerprint tests, since these run only for 5s but the start time of the MecResponseApp in the test scenario is 5s. A later commit will therefore increase the start time for MecResponseApp and other apps having this issue.
In the recent refactoring, the localUePort was removed from the MecBaseApp. Since it is required in the MecRTVideoStreamingReciever, this commit adds it there. Note that this problem was not detected by the fingerprint tests, since these run only for 5s but the start time of the MecRTVideoStreaming in the test scenario is a random value of up to 90s. A later commit will therefore increase the fingerprint time for MecRTVideoStreamingReceiver and other apps having this issue.
In the recent refactorings, the RNIService was renamed to RniService. However, not all service names were adapted. As a consequence, in the service registry the Service was registered correctly with the name "RniService" but later requested as "RNIService" leading to a situation where the service is not found and not available. This caused a segment violation since the service pointer was not checked for being null. This fix corrects the naming and also adds a check to determine if the service pointer is null.
Collaborator
|
Thank you very much for your contribution! Please allow me a few days to review and merge it. As for the refactoring work: more, radical changes are in the queue :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest refactorings (which are great by the way, thank you for your efforts in refactoring the code in general! 👍) have introduced two issues leading to a non-functional MecResponseApp:
Both problems were not detected by the fingerprint tests, since the MecResponseApp has a start time at 5s, being equal to the fingerprint end time of 5s. (Problem occurs at 5s 034ms.)