Skip to content

Document how to log with JSON format#1929

Merged
hmpf merged 1 commit into
mainfrom
support-logging-to-json
May 8, 2026
Merged

Document how to log with JSON format#1929
hmpf merged 1 commit into
mainfrom
support-logging-to-json

Conversation

@hmpf

@hmpf hmpf commented May 8, 2026

Copy link
Copy Markdown
Contributor

Scope and purpose

Allows structured logs controlled by us.

This does not change any code, and it's use optional.

This pull request

  • adds/changes/removes a dependency

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Argus can be found in the
Development docs.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation, including updates to the user manual if feature flow or UI is considerably changed
  • Linted/formatted the code with ruff and djLint, easiest by using pre-commit
  • The first line of the commit message continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See our how-to
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done
  • If this results in changes in the UI: Added screenshots of the before and after
  • If this results in changes to the database model: Updated the ER diagram

* Add optional dependency to python-json-logger
@hmpf hmpf self-assigned this May 8, 2026
@hmpf hmpf added documentation Improvements or additions to documentation dependencies Run `tox -r` before testing locally, dependencies have changed logging production Anything especially useful when running in production. labels May 8, 2026
@sonarqubecloud

sonarqubecloud Bot commented May 8, 2026

Copy link
Copy Markdown

@hmpf hmpf mentioned this pull request May 8, 2026
8 tasks
@github-actions

github-actions Bot commented May 8, 2026

Copy link
Copy Markdown

Test results

    8 files  1 712 suites   3m 7s ⏱️
  933 tests   932 ✅ 1 💤 0 ❌
7 464 runs  7 456 ✅ 8 💤 0 ❌

Results for commit 761a966.

@codecov

codecov Bot commented May 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.60%. Comparing base (7c04efb) to head (761a966).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1929   +/-   ##
=======================================
  Coverage   88.60%   88.60%           
=======================================
  Files         146      146           
  Lines        7093     7093           
=======================================
  Hits         6285     6285           
  Misses        808      808           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aleksfl aleksfl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much to comment, instructions and dependency work when tested.

@hmpf hmpf merged commit 8a3dcda into main May 8, 2026
24 checks passed
@hmpf hmpf deleted the support-logging-to-json branch May 8, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Run `tox -r` before testing locally, dependencies have changed documentation Improvements or additions to documentation logging production Anything especially useful when running in production.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants