Improve dropdown filter UX and fix tag selection#1887
Conversation
a32abdc to
2d4b7ac
Compare
Test naming conventionAll new test names follow the convention. 👍 |
Test results 8 files 1 712 suites 3m 6s ⏱️ Results for commit db0c9f2. ♻️ This comment has been updated with latest results. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1887 +/- ##
=======================================
Coverage 88.60% 88.60%
=======================================
Files 146 146
Lines 7089 7093 +4
=======================================
+ Hits 6281 6285 +4
Misses 808 808 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ebbb4f2 to
4a39142
Compare
0bd9a21 to
d59dc8b
Compare
@johannaengland |
johannaengland
left a comment
There was a problem hiding this comment.
I really like the look! But my comment about changing the two views from class based views back to function based views is still open - you said it was a rebase mistake, but it has not been changed back
It has been reverted now though 🙈 |
1bd9586 to
727a9f6
Compare
727a9f6 to
db0c9f2
Compare
|






Scope and purpose
Fixes #1887.
Replaces Choices.js type-ahead filters with dropdown-based search widgets and fixes several UX issues with the new implementation.
Screen recording
type-ahead-redesign-compressed.mp4
Changes
outerHTMLswap of.show-selected-boxcaused DaisyUI's.dropdown-contentopacity transition to briefly fire. Fixed by addingdropdown-openclass during htmx request/settle cycle.bordertoborder-base-content/20for better visibility on white dropdown backgrounds.Contributor Checklist