refactor: SecurityConfig 및 JwtAuthenticationValidationFilter 리팩토링 #23
Merged
Conversation
- 사용되지 않는 import(BcryptPasswordEncoder, PasswordEncoder 등) 제거 - JwtAuthenticationValidationFilter를 open class로 변경하여 상속 가능하도록 수정 - 불필요한 import 삭제(kotlin.jvm.java)로 코드 정리
…onValidator 테스트 추가 - JwtAuthenticationValidationFilter의 필터 동작 시나리오 단위 테스트 작성 - Jwt 인증 실패, 검증기 미통과 시 처리 로직 검증 테스트 작성 - MemberStatusJwtAuthenticationValidator의 회원 상태 유효성 검증 테스트 추가 - 테스트에서 Mocked Repository 기반 동작 확인 및 검증 로직 보완
|
Codex Review: Didn't find any major issues. You're on a roll. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 작업 개요
SecurityConfig 및 JwtAuthenticationValidationFilter 리팩토링
JwtAuthenticationValidationFilter 및 MemberStatusJwtAuthenticatonValidator 테스트 추가
🔗 관련 이슈
✨ 변경 사항
🧪 테스트
✅ 체크리스트
feature/,fix/,hotfix/등)💬 리뷰어에게
@codex