You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
test(sandbox): Isolate WSL detection in backend selection tests #947
TestSelectBackendChoosesPlatformAdapterWithFallback mocks GOOS and executable lookup, but backend selection still reads the host's real WSL state. On WSL2, the missing-helper case returns BackendWSL instead of the intended non-WSL BackendUnavailable result.
Proposed change
Allow backend selection tests to inject WSL detection while preserving real detection as the production default. Add coverage for both non-WSL and WSL2 fallback behavior.
Acceptance criteria
go test ./internal/sandbox -run TestSelectBackendChoosesPlatformAdapterWithFallback/linux_helper_missing_falls_back_explicitly -count=1 passes on WSL and non-WSL hosts.
Approved after rechecking current main. Backend-selection tests still consult the real host WSL state, so the reported non-WSL expectation can change on WSL. The requested injection seam and WSL/non-WSL coverage are appropriately scoped. PR #948 is already active; please coordinate there rather than opening a duplicate.
Activity
gnanam1990 commentedon Aug 25, 2026
Approved after rechecking current
main. Backend-selection tests still consult the real host WSL state, so the reported non-WSL expectation can change on WSL. The requested injection seam and WSL/non-WSL coverage are appropriately scoped. PR #948 is already active; please coordinate there rather than opening a duplicate.