Skip to content

launch form: rotate meta_key with the salt on 409 so an edited retry is not stuck - #3

Merged
kevincodex1 merged 1 commit into
mainfrom
fix/meta-key-retry
Sep 7, 2026
Merged

kevincodex1 merged 1 commit into
mainfrom
fix/meta-key-retry

Conversation

@kevincodex1

@kevincodex1 kevincodex1 commented Sep 7, 2026 •

Copy link
Copy Markdown
Member

A metadata key is locked to the details it was first registered with. The form kept its key for the whole session and only rotated the salt on 409, so after a failed or cancelled attempt an edit to name/image/etc. hit 409 on every retry. Now a 409 starts a fresh attempt: new key and new salt together, and the new key stays fixed through findSalt. Identical retries remain idempotent (same key, same salt, 200).

Summary by CodeRabbit

  • Bug Fixes
    • Improved launch retry handling for conflicting metadata.
    • Metadata registration now preserves the correct key across retries and rotates the key and salt when conflicts require another attempt.

…is not stuck

A metadata key is locked to the details it was first registered with. The form kept
its key for the whole session and only rotated the salt on 409, so after a failed or
cancelled attempt an edit to name/image/etc. hit 409 on every retry. Now a 409 starts
a fresh attempt: new key and new salt together, and the new key stays fixed through
findSalt. Identical retries remain idempotent (same key, same salt, 200).
@coderabbitai

coderabbitai Bot commented Sep 7, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Essentials

Run ID: f6b88c02-6e63-4c96-9166-85bc6c1df3f1

📥 Commits

Reviewing files that changed from the base of the PR and between c89bbc0 and 2b06050.

📒 Files selected for processing (1)
  • app/src/components/launchpad/LaunchForm.tsx

Included review availability: 1 review is currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


📝 Walkthrough

Walkthrough

Launch metadata registration now keeps the metadata key mutable during an attempt. A 409 response rotates both the metadata key and salt before retrying.

Changes

Launch metadata retry handling

Layer / File(s) Summary
Mutable metadata retry state
app/src/components/launchpad/LaunchForm.tsx
The launch attempt initializes a mutable metadata key from its persistent reference. A 409 response generates and stores a new metadata key and salt before retrying registration.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 2b060

Launch retries now refresh both metadata key and salt after a 409 conflict while preserving values for identical retries. No current merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: rotating the metadata key with the salt after a 409 conflict so edited retries can proceed.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/meta-key-retry

Comment @coderabbitai help to get the list of available commands.

@kevincodex1
kevincodex1 merged commit 5071fdb into main Sep 7, 2026
3 checks passed
kevincodex1 pushed a commit to philpof102-svg/openlaunch that referenced this pull request Sep 10, 2026
Dig Twigpine#2 (Grok Super B-20 stock UX): sticky « Quote = SYMBOL (registry) »
chip beside the Stock picker, Reg S / issuer disclaimer adjacent to the
pick, and CTA fail-closed with an explicit chip when Stock is selected
with no registry pick. Registry-gated via existing /api/quotes only.

Deferred: dig Twigpine#3 above-fold Stock for Instant (Instant Advanced path
ships separately on feat/ol-stock-ux).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant