Repository navigation
launch form: rotate meta_key with the salt on 409 so an edited retry is not stuck - #3
Conversation
…is not stuck A metadata key is locked to the details it was first registered with. The form kept its key for the whole session and only rotated the salt on 409, so after a failed or cancelled attempt an edit to name/image/etc. hit 409 on every retry. Now a 409 starts a fresh attempt: new key and new salt together, and the new key stays fixed through findSalt. Identical retries remain idempotent (same key, same salt, 200).
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (1)
Included review availability: 1 review is currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. 📝 WalkthroughWalkthroughLaunch metadata registration now keeps the metadata key mutable during an attempt. A ChangesLaunch metadata retry handling
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to Launch retries now refresh both metadata key and salt after a 409 conflict while preserving values for identical retries. No current merge-blocking risk is identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
Dig Twigpine#2 (Grok Super B-20 stock UX): sticky « Quote = SYMBOL (registry) » chip beside the Stock picker, Reg S / issuer disclaimer adjacent to the pick, and CTA fail-closed with an explicit chip when Stock is selected with no registry pick. Registry-gated via existing /api/quotes only. Deferred: dig Twigpine#3 above-fold Stock for Instant (Instant Advanced path ships separately on feat/ol-stock-ux).
A metadata key is locked to the details it was first registered with. The form kept its key for the whole session and only rotated the salt on 409, so after a failed or cancelled attempt an edit to name/image/etc. hit 409 on every retry. Now a 409 starts a fresh attempt: new key and new salt together, and the new key stays fixed through findSalt. Identical retries remain idempotent (same key, same salt, 200).
Summary by CodeRabbit