Repository navigation
Conversation
Vasanthdev2004
left a comment
There was a problem hiding this comment.
Reviewed on head 58e7346 — CI red 🔴 (both Determinism jobs fail)
This PR adds a determinism-checks workflow, a signal summary builder, and a test file. The signalSummary.ts logic and tests look well-structured (manifest comparison, historical recurrence tracking, temporal classification). However, the CI workflow cannot run because the referenced npm scripts don't exist:
🔴 Both CI jobs fail:
- Determinism job:
error: Script not found "test:determinism"— the stepbun run test:determinismfails immediately - Metadata Check job:
error: Script not found "determinism:scan:json"— the stepbun run determinism:scan:jsonfails immediately
The workflow also references bun run determinism:emit (in the "Emit normalized artifacts" steps), which would also fail if reached.
What's missing: The package.json scripts section needs entries for:
test:determinism→ should run the test file insrc/determinism/tests/serialization/determinism:emit→ should produce artifact manifestsdeterminism:scan:json→ should produce scan reports
Other observations:
- The PR description says "This PR is for validation only and will be reverted/closed after verification" — is this still the plan? If so, should it just be closed?
- The workflow path trigger includes
src/determinism/**andscripts/determinism/**— good scoping - Action SHAs verified:
checkout@11bd719✅,setup-bun@4bc047a✅,setup-node@49933ea✅,upload-artifact@6546280✅ - The
signalSummary.tslogic is clean — manifest hashing, sorted-union comparison, recurrence stats with mode frequency - Tests cover the two main paths (no history vs. history available) and verify delta density calculation
Verdict: Needs changes — the workflow is non-functional without the package.json scripts. Also needs clarification on whether this is still a "temporary validation PR" per the description.
gnanam1990
left a comment
There was a problem hiding this comment.
I can’t approve this yet. The signal-summary code/tests look fine, but the PR also adds a CI workflow that currently references determinism scripts that do not exist, so the workflow fails on its own setup. Please fix the workflow/script wiring first, then I’m happy to recheck.
|
closing as stale |
Temporary validation PR for determinism signal-summary CI behavior.
Purpose:
This PR is for validation only and will be reverted/closed after verification.