Repository navigation
refactor(openai-shim): extract tool conversion - #2006
Conversation
📝 WalkthroughWalkthroughThe change extracts OpenAI-compatible tool conversion and raw text tool-call parsing into dedicated modules, adds focused regression tests, and updates ChangesOpenAI shim tool handling
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
bb5b55d to
51fad44
Compare
51fad44 to
077e5dc
Compare
554cef5 to
24443f9
Compare
24443f9 to
d611660
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/services/api/openaiShim/rawToolCallParsing.test.ts`:
- Around line 8-23: Add negative-case assertions to the test covering
couldBeRawToolCallsRequestedPrefix: verify unrelated prose and a diverging
partial prefix return false, while preserving the existing true assertion for
the valid “Tool calls” prefix.
In `@src/services/api/openaiShim/rawToolCallParsing.ts`:
- Line 17: Replace FENCED_TOOL_CALL_RE-based extraction with the existing
extractBalancedJson parser: detect fenced openings, calculate each opening brace
position, parse the balanced JSON, and require the closing fence immediately
after optional whitespace. Preserve the current fenced-block processing and
range behavior, skipping malformed or non-fenced matches.
In `@src/services/api/openaiShim/toolConversion.test.ts`:
- Around line 1-97: Add a focused test covering the non-strict Gemini path in
convertTools: pass a simple object schema with isGemini: true and
disableStrictTools: false, then assert the generated function parameters omit
additionalProperties rather than setting it to false. Keep the existing
strict-path tests unchanged.
In `@src/services/api/openaiShim/toolConversion.ts`:
- Around line 84-91: In the Agent handling block, prevent schema.required from
aliasing the caller’s input_schema.required array before appending keys. Clone
an existing required array into a new array, while retaining an empty array when
it is absent or invalid, then push missing message and subagent_type entries
onto that cloned array.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 80e52dbd-15bb-430e-82d7-ac6dd762e960
📒 Files selected for processing (7)
src/services/api/openaiShim.ollamaTextToolCalls.test.tssrc/services/api/openaiShim.test.tssrc/services/api/openaiShim.tssrc/services/api/openaiShim/rawToolCallParsing.test.tssrc/services/api/openaiShim/rawToolCallParsing.tssrc/services/api/openaiShim/toolConversion.test.tssrc/services/api/openaiShim/toolConversion.ts
💤 Files with no reviewable changes (1)
- src/services/api/openaiShim.test.ts
📜 Review details
⏰ Context from checks skipped due to timeout. (3)
- GitHub Check: smoke-and-tests (24.11.x)
- GitHub Check: smoke-and-tests (22)
- GitHub Check: typecheck
🧰 Additional context used
📓 Path-based instructions (5)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
TypeScript code in this repository must use strict mode and ESM imports.
**/*.{ts,tsx}: Follow the existing code style and architectural patterns in touched TypeScript and TSX files.
Add or update tests when TypeScript or TSX changes affect behavior.
Review AI-generated TypeScript and TSX changes for correctness beyond compilation, consistency with repository architecture and style, unnecessary generated noise, and subtle bugs before submission.
Files:
src/services/api/openaiShim.ollamaTextToolCalls.test.tssrc/services/api/openaiShim/rawToolCallParsing.test.tssrc/services/api/openaiShim/toolConversion.tssrc/services/api/openaiShim/toolConversion.test.tssrc/services/api/openaiShim/rawToolCallParsing.tssrc/services/api/openaiShim.ts
**/*
📄 CodeRabbit inference engine (CONTRIBUTING.md)
**/*: Keep pull requests focused on one problem or feature; do not mix unrelated cleanup, fixes, features, or refactors into the same change.
Preserve existing repository patterns unless intentionally refactoring them, and prefer small, readable changes over broad rewrites.
Do not reformat unrelated files, and keep comments useful and concise.
Update documentation when setup, commands, or user-facing behavior changes.
When changing provider behavior, avoid breaking third-party providers, test the exact provider/model path changed when possible, explicitly identify affected providers, and document limitations or follow-up work.
Do not assign or use provider tags; provider tags are controlled and applied by maintainers.
Run the relevant validation checks locally before submitting; CI-required checks includebun run check,bun run test:full, provider tests when applicable, typechecks, andbun run security:pr-scan. Web changes additionally requirebun run web:typecheckandbun run web:build.
Dependency changes must have a concrete project benefit, such as fixing a bug, addressing a security issue, or supporting an approved feature; preference alone is insufficient.
Do not change the project's language, core runtime, dependency stack, or significantly restructure dependencies without prior maintainer agreement.
Before implementing a new feature or other non-trivial change, open an issue to establish scope and alignment with the project roadmap.
Files:
src/services/api/openaiShim.ollamaTextToolCalls.test.tssrc/services/api/openaiShim/rawToolCallParsing.test.tssrc/services/api/openaiShim/toolConversion.tssrc/services/api/openaiShim/toolConversion.test.tssrc/services/api/openaiShim/rawToolCallParsing.tssrc/services/api/openaiShim.ts
⚙️ CodeRabbit configuration file
**/*: Apply the OpenClaude maintainer review rubric from AGENTS.md. Review the current diff, not stale discussion context. Separate real blockers from suggestions. Do not request changes for vague style churn. Treat approval as merge-ready from CodeRabbit's side, pending required human review and GitHub Checks. If checks are failing or unavailable, say so clearly instead of implying the PR is fully ready.
Files:
src/services/api/openaiShim.ollamaTextToolCalls.test.tssrc/services/api/openaiShim/rawToolCallParsing.test.tssrc/services/api/openaiShim/toolConversion.tssrc/services/api/openaiShim/toolConversion.test.tssrc/services/api/openaiShim/rawToolCallParsing.tssrc/services/api/openaiShim.ts
**/*.{test,spec}.{ts,tsx}
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Run focused tests for changed behavior and ensure provider-specific changes include the relevant provider tests.
Files:
src/services/api/openaiShim.ollamaTextToolCalls.test.tssrc/services/api/openaiShim/rawToolCallParsing.test.tssrc/services/api/openaiShim/toolConversion.test.ts
{src/services/api/**,src/integrations/**,src/utils/model/**,src/utils/provider*.ts,src/commands/provider/**}
⚙️ CodeRabbit configuration file
{src/services/api/**,src/integrations/**,src/utils/model/**,src/utils/provider*.ts,src/commands/provider/**}: Review provider routing, model selection, env precedence, auth/token handling, OpenAI-compatible shims, retries, proxy behavior, and outbound HTTP behavior with high scrutiny. Block on silent default changes, hidden fallback expansion, credential reuse mistakes, hardcoded provider assumptions, or new network reach that is not intentional and documented.
Files:
src/services/api/openaiShim.ollamaTextToolCalls.test.tssrc/services/api/openaiShim/rawToolCallParsing.test.tssrc/services/api/openaiShim/toolConversion.tssrc/services/api/openaiShim/toolConversion.test.tssrc/services/api/openaiShim/rawToolCallParsing.tssrc/services/api/openaiShim.ts
{src/**/*.test.ts,src/**/*.test.tsx,tests/**,scripts/**/*.test.ts,vscode-extension/**/*.test.js}
⚙️ CodeRabbit configuration file
{src/**/*.test.ts,src/**/*.test.tsx,tests/**,scripts/**/*.test.ts,vscode-extension/**/*.test.js}: Review tests for meaningful coverage of the changed behavior, isolation of global/env/config state, async cleanup, fake timers, provider profile leaks, and Windows-compatible assumptions. Block when risky runtime changes lack focused regression coverage or tests assert implementation details while missing the user-visible behavior.
Files:
src/services/api/openaiShim.ollamaTextToolCalls.test.tssrc/services/api/openaiShim/rawToolCallParsing.test.tssrc/services/api/openaiShim/toolConversion.test.ts
🔇 Additional comments (6)
src/services/api/openaiShim.ts (2)
772-794: LGTM!
847-863: LGTM!src/services/api/openaiShim.ollamaTextToolCalls.test.ts (1)
13-14: 📐 Maintainability & Code QualityNo issue:
src/services/api/openaiShim.test.ts:6624-6628already covers the façade-level sequence path andollama_tc_*ids, so this retargeting does not leave the injected generator untested.> Likely an incorrect or invalid review comment.src/services/api/openaiShim/toolConversion.ts (1)
1-83: LGTM!Also applies to: 92-105
src/services/api/openaiShim/rawToolCallParsing.ts (1)
1-141: LGTM!Also applies to: 163-239
src/services/api/openaiShim/rawToolCallParsing.test.ts (1)
1-79: 📐 Maintainability & Code QualityNo direct tests for
parseTextToolCalls/extractBalancedJson/stripRangesin this dedicated suite.This file only covers the raw "Tool calls requested:" prefix/repair functions, but the "Embedded text tool-call recovery" layer description states fenced/bare JSON tool-call parsing is "tested across valid and malformed inputs" and lists this file as covering it. Please confirm that suite exists in
openaiShim.test.ts(not in this review batch) — if not, these are the most algorithmically subtle functions in the module (regex backtracking, balanced-brace counting, dedup) and warrant direct unit tests here rather than only indirect façade coverage.Source: Path instructions
d611660 to
0b8c30f
Compare
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/services/api/openaiShim.ts`:
- Around line 772-775: Move the imports for convertToolsModule and
normalizeSchemaForOpenAIModule from their mid-file locations into the existing
top-of-file import block in openaiShim.ts, preserving their paths and aliases
without other changes.
In `@src/services/api/openaiShim/rawToolCallParsing.test.ts`:
- Around line 1-7: Extend the tests for the exported stripRanges helper in
rawToolCallParsing.test.ts with direct coverage of its sort-and-splice behavior:
provide unsorted ranges and assert that the corresponding text segments are
removed without leaking raw JSON or altering the remaining text.
In `@src/services/api/openaiShim/rawToolCallParsing.ts`:
- Around line 208-220: Update the bare-name handling in the parsed tool-call
logic so parsed.arguments is processed through the existing parseArguments
helper, matching the type:function branch. Preserve the empty-object fallback
for missing arguments and ensure stringified JSON arguments produce a
Record<string, unknown> for ParsedTextToolCall.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 5543bb63-527e-4ef3-978e-95672a669f0b
📒 Files selected for processing (7)
src/services/api/openaiShim.ollamaTextToolCalls.test.tssrc/services/api/openaiShim.test.tssrc/services/api/openaiShim.tssrc/services/api/openaiShim/rawToolCallParsing.test.tssrc/services/api/openaiShim/rawToolCallParsing.tssrc/services/api/openaiShim/toolConversion.test.tssrc/services/api/openaiShim/toolConversion.ts
💤 Files with no reviewable changes (1)
- src/services/api/openaiShim.test.ts
📜 Review details
⏰ Context from checks skipped due to timeout. (3)
- GitHub Check: smoke-and-tests (22)
- GitHub Check: smoke-and-tests (24.11.x)
- GitHub Check: typecheck
🧰 Additional context used
📓 Path-based instructions (4)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
TypeScript code in this repository must use strict mode and ESM imports.
**/*.{ts,tsx}: Add or update tests when a TypeScript or TSX change affects behavior.
Run the relevant TypeScript validation checks for changed code, includingbun run typecheckand, when applicable,bun run typecheck:type-tests.
Files:
src/services/api/openaiShim.ollamaTextToolCalls.test.tssrc/services/api/openaiShim/toolConversion.test.tssrc/services/api/openaiShim/toolConversion.tssrc/services/api/openaiShim/rawToolCallParsing.test.tssrc/services/api/openaiShim.tssrc/services/api/openaiShim/rawToolCallParsing.ts
**/*
📄 CodeRabbit inference engine (CONTRIBUTING.md)
**/*: Preserve existing repository patterns unless intentionally refactoring them.
Keep changes small, readable, and focused; avoid broad rewrites or unrelated cleanup.
Do not reformat unrelated files, and keep comments useful and concise.
Update documentation when setup, commands, or user-facing behavior changes.
Review AI-generated changes for correctness, style consistency, unnecessary noise, and adherence to project architecture before submitting them.
Provider changes must follow the documented integration patterns indocs/integrations/overview.mdand the focused guides underdocs/integrations/how-to/.
When changing provider behavior, avoid breaking third-party providers and test the exact provider/model path changed when possible.
Provider pull requests must explicitly identify affected providers, limitations, and follow-up work.
Run the narrowest meaningful validation command for the touched area, and ensure relevant CI checks pass before merging.
Usebun installto install dependencies and the repository's Bun scripts for building, testing, smoke testing, and development.
Dependency changes require a concrete project benefit such as a bug fix, security issue, or approved feature; preference alone is insufficient.
Do not change the project's language, core runtime, or dependency stack, or introduce a new runtime, without prior maintainer agreement.
Keep each pull request focused on one issue or clearly scoped improvement and avoid bundling unrelated fixes, features, or refactors.
Files:
src/services/api/openaiShim.ollamaTextToolCalls.test.tssrc/services/api/openaiShim/toolConversion.test.tssrc/services/api/openaiShim/toolConversion.tssrc/services/api/openaiShim/rawToolCallParsing.test.tssrc/services/api/openaiShim.tssrc/services/api/openaiShim/rawToolCallParsing.ts
⚙️ CodeRabbit configuration file
**/*: Apply the OpenClaude maintainer review rubric from AGENTS.md. Review the current diff, not stale discussion context. Separate real blockers from suggestions. Do not request changes for vague style churn. Treat approval as merge-ready from CodeRabbit's side, pending required human review and GitHub Checks. If checks are failing or unavailable, say so clearly instead of implying the PR is fully ready.
Files:
src/services/api/openaiShim.ollamaTextToolCalls.test.tssrc/services/api/openaiShim/toolConversion.test.tssrc/services/api/openaiShim/toolConversion.tssrc/services/api/openaiShim/rawToolCallParsing.test.tssrc/services/api/openaiShim.tssrc/services/api/openaiShim/rawToolCallParsing.ts
{src/services/api/**,src/integrations/**,src/utils/model/**,src/utils/provider*.ts,src/commands/provider/**}
⚙️ CodeRabbit configuration file
{src/services/api/**,src/integrations/**,src/utils/model/**,src/utils/provider*.ts,src/commands/provider/**}: Review provider routing, model selection, env precedence, auth/token handling, OpenAI-compatible shims, retries, proxy behavior, and outbound HTTP behavior with high scrutiny. Block on silent default changes, hidden fallback expansion, credential reuse mistakes, hardcoded provider assumptions, or new network reach that is not intentional and documented.
Files:
src/services/api/openaiShim.ollamaTextToolCalls.test.tssrc/services/api/openaiShim/toolConversion.test.tssrc/services/api/openaiShim/toolConversion.tssrc/services/api/openaiShim/rawToolCallParsing.test.tssrc/services/api/openaiShim.tssrc/services/api/openaiShim/rawToolCallParsing.ts
{src/**/*.test.ts,src/**/*.test.tsx,tests/**,scripts/**/*.test.ts,vscode-extension/**/*.test.js}
⚙️ CodeRabbit configuration file
{src/**/*.test.ts,src/**/*.test.tsx,tests/**,scripts/**/*.test.ts,vscode-extension/**/*.test.js}: Review tests for meaningful coverage of the changed behavior, isolation of global/env/config state, async cleanup, fake timers, provider profile leaks, and Windows-compatible assumptions. Block when risky runtime changes lack focused regression coverage or tests assert implementation details while missing the user-visible behavior.
Files:
src/services/api/openaiShim.ollamaTextToolCalls.test.tssrc/services/api/openaiShim/toolConversion.test.tssrc/services/api/openaiShim/rawToolCallParsing.test.ts
🔇 Additional comments (8)
src/services/api/openaiShim/toolConversion.ts (3)
12-57: LGTM!
84-91: Aliasing fix confirmed. The[...schema.required]clone resolves the earlier in-place mutation of the caller'sinput_schema, and the new test attoolConversion.test.tsLine 100 pins it.
3-10: 🗄️ Data Integrity & IntegrationRemove this concern:
function.strictis not emitted
convertToolsonly sendsname,description, andparameters; strictness is enforced insideparameters, so there’s no request-payload change here.> Likely an incorrect or invalid review comment.src/services/api/openaiShim/toolConversion.test.ts (1)
72-116: LGTM!src/services/api/openaiShim/rawToolCallParsing.ts (1)
46-97: LGTM!Also applies to: 99-141, 155-189
src/services/api/openaiShim/rawToolCallParsing.test.ts (1)
28-48: LGTM!Also applies to: 76-91
src/services/api/openaiShim.ts (1)
777-794: LGTM!Also applies to: 858-863
src/services/api/openaiShim.ollamaTextToolCalls.test.ts (1)
13-14: 🎯 Functional CorrectnessThe ID checks are order-independent. This suite only matches
ollama_tc_\d+, so the extra raw parser import doesn’t make these assertions brittle.> Likely an incorrect or invalid review comment.
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/services/api/openaiShim/rawToolCallParsing.ts (1)
161-166: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick winPreserve valid tool calls followed by prose.
These guards discard a balanced tool call whenever remaining text is non-empty and does not start with
{. Consequently, inputs such as a fenced call followed by “I’ll run that now” — or multiple fenced calls — return no calls. Accept the validated range and leave trailing prose forstripRanges; add regression coverage for fenced and bare calls followed by text.🐛 Suggested fix
- const after = text.slice(fenceEnd).trimStart() - if (after.length > 0 && !after.startsWith('{')) continue const range: [number, number] = [fenceStart, fenceEnd] - const after = text.slice(start + raw.length).trimStart() - if (after.length > 0 && !after.startsWith('{')) continue const range: [number, number] = [start, start + raw.length]Also applies to: 183-184
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/services/api/openaiShim/rawToolCallParsing.ts` around lines 161 - 166, Remove the trailing-text guards in the tool-call parsing flow around the closing-fence handling and the corresponding bare-call path, so a successfully validated balanced call is accepted regardless of remaining prose or additional calls. Preserve the validated ranges so stripRanges can remove calls while leaving trailing text intact, and add regression coverage for fenced and bare calls followed by prose.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@src/services/api/openaiShim/rawToolCallParsing.ts`:
- Around line 161-166: Remove the trailing-text guards in the tool-call parsing
flow around the closing-fence handling and the corresponding bare-call path, so
a successfully validated balanced call is accepted regardless of remaining prose
or additional calls. Preserve the validated ranges so stripRanges can remove
calls while leaving trailing text intact, and add regression coverage for fenced
and bare calls followed by prose.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 85114f2f-cae0-477d-b8d8-dc97d29f685a
📒 Files selected for processing (3)
src/services/api/openaiShim.tssrc/services/api/openaiShim/rawToolCallParsing.test.tssrc/services/api/openaiShim/rawToolCallParsing.ts
📜 Review details
⏰ Context from checks skipped due to timeout. (3)
- GitHub Check: typecheck
- GitHub Check: smoke-and-tests (24.11.x)
- GitHub Check: smoke-and-tests (22)
🧰 Additional context used
📓 Path-based instructions (4)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
TypeScript code in this repository must use strict mode and ESM imports.
**/*.{ts,tsx}: Add or update tests when a TypeScript or TSX change affects behavior.
Run the relevant TypeScript validation checks for changed code, includingbun run typecheckand, when applicable,bun run typecheck:type-tests.
Files:
src/services/api/openaiShim/rawToolCallParsing.test.tssrc/services/api/openaiShim.tssrc/services/api/openaiShim/rawToolCallParsing.ts
**/*
📄 CodeRabbit inference engine (CONTRIBUTING.md)
**/*: Preserve existing repository patterns unless intentionally refactoring them.
Keep changes small, readable, and focused; avoid broad rewrites or unrelated cleanup.
Do not reformat unrelated files, and keep comments useful and concise.
Update documentation when setup, commands, or user-facing behavior changes.
Review AI-generated changes for correctness, style consistency, unnecessary noise, and adherence to project architecture before submitting them.
Provider changes must follow the documented integration patterns indocs/integrations/overview.mdand the focused guides underdocs/integrations/how-to/.
When changing provider behavior, avoid breaking third-party providers and test the exact provider/model path changed when possible.
Provider pull requests must explicitly identify affected providers, limitations, and follow-up work.
Run the narrowest meaningful validation command for the touched area, and ensure relevant CI checks pass before merging.
Usebun installto install dependencies and the repository's Bun scripts for building, testing, smoke testing, and development.
Dependency changes require a concrete project benefit such as a bug fix, security issue, or approved feature; preference alone is insufficient.
Do not change the project's language, core runtime, or dependency stack, or introduce a new runtime, without prior maintainer agreement.
Keep each pull request focused on one issue or clearly scoped improvement and avoid bundling unrelated fixes, features, or refactors.
Files:
src/services/api/openaiShim/rawToolCallParsing.test.tssrc/services/api/openaiShim.tssrc/services/api/openaiShim/rawToolCallParsing.ts
⚙️ CodeRabbit configuration file
**/*: Apply the OpenClaude maintainer review rubric from AGENTS.md. Review the current diff, not stale discussion context. Separate real blockers from suggestions. Do not request changes for vague style churn. Treat approval as merge-ready from CodeRabbit's side, pending required human review and GitHub Checks. If checks are failing or unavailable, say so clearly instead of implying the PR is fully ready.
Files:
src/services/api/openaiShim/rawToolCallParsing.test.tssrc/services/api/openaiShim.tssrc/services/api/openaiShim/rawToolCallParsing.ts
{src/services/api/**,src/integrations/**,src/utils/model/**,src/utils/provider*.ts,src/commands/provider/**}
⚙️ CodeRabbit configuration file
{src/services/api/**,src/integrations/**,src/utils/model/**,src/utils/provider*.ts,src/commands/provider/**}: Review provider routing, model selection, env precedence, auth/token handling, OpenAI-compatible shims, retries, proxy behavior, and outbound HTTP behavior with high scrutiny. Block on silent default changes, hidden fallback expansion, credential reuse mistakes, hardcoded provider assumptions, or new network reach that is not intentional and documented.
Files:
src/services/api/openaiShim/rawToolCallParsing.test.tssrc/services/api/openaiShim.tssrc/services/api/openaiShim/rawToolCallParsing.ts
{src/**/*.test.ts,src/**/*.test.tsx,tests/**,scripts/**/*.test.ts,vscode-extension/**/*.test.js}
⚙️ CodeRabbit configuration file
{src/**/*.test.ts,src/**/*.test.tsx,tests/**,scripts/**/*.test.ts,vscode-extension/**/*.test.js}: Review tests for meaningful coverage of the changed behavior, isolation of global/env/config state, async cleanup, fake timers, provider profile leaks, and Windows-compatible assumptions. Block when risky runtime changes lack focused regression coverage or tests assert implementation details while missing the user-visible behavior.
Files:
src/services/api/openaiShim/rawToolCallParsing.test.ts
🔇 Additional comments (3)
src/services/api/openaiShim/rawToolCallParsing.ts (1)
38-44: LGTM!Also applies to: 46-79, 81-97, 129-141, 194-247
src/services/api/openaiShim/rawToolCallParsing.test.ts (1)
1-8: LGTM!Also applies to: 10-27, 29-49, 51-78, 80-133
src/services/api/openaiShim.ts (1)
113-113: LGTM!Also applies to: 165-179, 791-804, 857-861
2 participants
Summary
Extracts tool-schema conversion and raw JSON tool-call parsing into
toolConversion.tsandrawToolCallParsing.ts.The group owns schema sanitization, deferred-tool filtering, raw Gemini/text tool-call parsing, and bounded truncated-JSON repair. The façade delegates these cohesive tool boundaries.
Independent merge
0effa0f42b6dbc6a4800e19f4b2d8d588269906b.jatmn/openclaude:de-mono1-tools-and-json-parser.554cef505b208e920d0b8e0a6a92878ed2d11a1f.Source-file budget
openaiShim.ts: +59 / -326 = 385 changed lines, below the 1,500-line cap; tests excluded.Test migration
toolConversion.test.ts(97 lines / 4 tests) andrawToolCallParsing.test.ts(78 lines / 7 tests).Validation
bun run check: 7,194 passed / 2 skipped; only 10 pre-existing PowerShell governance failures remain on Linux.Prepared according to
CONTRIBUTING.mdandAGENTS.md.Summary by CodeRabbit
New Features
Bug Fixes
requiredhandling (no accidental optional promotion), and Gemini-mode adjustments, including better support for special tool definitions.Tests