Skip to content

p2p(kademlia): Unbounded address accumulation from Identify Push messages #429

Description

@euxaristia

Summary

Every Identify event copies advertised listen addresses into Kademlia without a per-peer maximum, TTL, or replacement policy (crates/gitlawb-node/src/p2p/mod.rs:365-371).

Impact

A peer advertising fresh valid multiaddrs over repeated Identify Push messages continuously inflates retained address state.

Remediation

  1. Enforce a small per-peer address maximum with eviction.
  2. Apply TTL to addresses.
  3. Rate-limit Identify Push processing.

Fix

Addressed in #410.

No activity

Activity on this issue will appear here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    crate:nodegitlawb-node — the serving node and REST APIkind:securityVulnerability fix or hardeningsev:mediumDegraded but workaround existssubsystem:peersPeer announce, discovery, and registry

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions