Repository navigation
feat(turbosign): schedule-on-send + TurboQuote send scheduling - #36
Merged
Merged
Conversation
- Send Signature and Prepare for Review now expose the eight reminder/
expiration schedule fields (durations JSON-string-encoded for the multipart
send path; expirationWarning may be 0).
- TurboQuote Send / Send With Deliverable / Create and Send expose the same
schedule as native JSON (durations as {value,unit} objects, native scalars).
Expiry is pinned to the quote's Valid Until (expireAfter ignored when on);
the reminder/warning cadence must fit inside it.
- README Operations table adds Send Reminder + fixes the Resend use-case; the
schedule capability and quote constraint are documented; PARITY.md records
sendReminder and the schedule support.
- Regression tests for both the signature and quote schedule paths.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds reminder/expiration scheduling to the send operations, so a workflow can configure reminders and expiration when it sends — for both signature documents and quotes. (The standalone Send Reminder operation already shipped; this adds the schedule to the send paths.)
TurboSign
Send Signature and Prepare for Review gain a "Reminder & Expiration Schedule" collection — the eight fields (
remindersEnabled,reminderDelay,reminderInterval,maxReminders,expirationEnabled,expireAfter,expirationWarning,expirationWarningInterval). Unset fields inherit the org defaults. These paths aremultipart/form-data, so each duration is JSON-string-encoded (the backend decodes it) — matching howrecipients/fieldsare already sent.expirationWarning: 0("never warn") is preserved; other zero-length durations are dropped as unset.TurboQuote
Send, Send With Deliverable, and Create and Send gain the same schedule. These are JSON endpoints, so durations ride as native
{value, unit}objects (not the multipart string form) and booleans/numbers are native. One constraint, baked into the field descriptions:Docs / meta
sendReminderand the schedule support on the prepare + quote-send paths.Verification
New jest suites for both schedule paths — the TurboQuote one (13 tests) asserts native-object JSON encoding across all three quote-send ops including the
createAndSendterminal send; run locally green.tsc/lint run in CI.🤖 Generated with Claude Code