Repository navigation
Conversation
TurboDocx DOCX Diff Report
Summary
🚀 Powered by TurboDocx | html-to-docxAutomated DOCX regression testing • Catch document generation bugs before they ship • 100% open source Generated by TurboDocx DOCX Diff workflow • Learn more |
58d8c2d to
f7f97b8
Compare
|
@elefevre please add yourself to the contributors in package.json and can get a maintainer to look at th is |
f7f97b8 to
88f86c1
Compare
|
Added myself to the contributors. |
|
Additional note: in the first approach, Claude actually implemented the necessary code directly, without using an external library. It actually felt reasonable (~50 lines of not-too-complex lines). But I wasn't sure how to test this and I didn't feel that I could stand by it. |
|
@elefevre |
| let imageProperties; | ||
| try { | ||
| imageProperties = sizeOf(imageBuffer); | ||
| imageProperties = await sizeOf(Readable.from(imageBuffer)); |
There was a problem hiding this comment.
Was there a reason to use the async streaming API (await sizeOf(Readable.from(imageBuffer))) over the synchronous buffer one (sizeOf.sync(imageBuffer))?
There was a problem hiding this comment.
Not really, I think I simply rushed through the documentation and didn't realize there was a sync function available. I don't see the benefit of using the async alternative here. I'll switch to using sync.
There was a problem hiding this comment.
@elefevre
Requested one clarification, before we merge this.
`image-size` is being flagged by vulnerability scanners such as Snyk: - Infinite loop on image type ICNS https://security.snyk.io/vuln/SNYK-JS-IMAGESIZE-17295814 - Infinite loop on image types HEIF, JP2, and JXL https://security.snyk.io/vuln/SNYK-JS-IMAGESIZE-17295814 Vulnerabilities are assessed as "High". Practical risks might be lower, as HEIF, JP2, JXL, ICNS are not standard web image formats. Still, `image-size` has been marked as archived (see https://github.com/image-size/image-size), so it is appropriate to switch to another library.
88f86c1 to
a352ef3
Compare
|
Now uses the |
|
@elefevre please point this to develop and I can merge it |
|
@elefevre, @amitsharma-turbodocx ported it, rebased it, and then kept the package.json contributors |
|
Thanks @elefevre — good catch, and the library comparison in your description was genuinely helpful. We've ported this to #227, branched off One deviation: we import from #227 is what we'll take through testing and merge from. Thanks again! |
image-sizeis being flagged by vulnerability scanners such as Snyk:Vulnerabilities are assessed as "High". Practical risk might be lower, as HEIF, JP2, JXL, ICNS are not standard web image formats.
Still,
image-sizeis now archived, so it might be appropriate to switch to another library anyway.Notes:
probe-image-size:It seems that
probe-image-sizeis a good choice, despite the several dependencies that it is pulling.Happy to adjust this PR upon your feedback!