feat(capture+review): scrub personal/proprietary identifiers from screenshots - #2
Draft
nicolasiscoding wants to merge 1 commit into
Draft
feat(capture+review): scrub personal/proprietary identifiers from screenshots#2nicolasiscoding wants to merge 1 commit into
nicolasiscoding wants to merge 1 commit into
Conversation
…eenshots guidewright-capture: add a scrub-before-screenshot step to the red-box loop + a 4th principle (never show real accounts/IDs/org names) + references/scrubbing.md with a parameterized, product-agnostic scrub snippet (email/org name/UUID -> placeholders), run last so a re-render can't restore the real text. guidewright-review: pre-publish check that flags any screenshot/alt-text/page text still carrying a real email, raw UUID, or non-generic org/customer name (walk step + checklist + lenses rubric). evals: add capture-scrubs-identifiers and review-catches-leaked-identifiers (+ leaky-howto fixture). Bump plugin 0.1.0 -> 0.2.0. Closes #1.
Member
Author
Eval run — all green ✅ (16/16 assertions)Ran the full behavioral suite for real (per eval: a performer agent follows the edited skill → a strict LLM judge scores each assertion). Not a dry-run.
New behavior confirmed:
No regression: the 3 pre-existing evals (recipe discipline, Diátaxis type-fit, planted-issue review) still pass with the edits in place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Makes DOM-scrubbing of personal/proprietary identifiers a built-in part of the capture flow, plus a pre-publish review check. Closes #1.
guidewright-capture
references/scrubbing.md: a parameterized, product-agnosticevaluate_scriptsnippet (login email, org/workspace name, UUID/tenant id -> neutral placeholders likeyou@example.com/ACME Corp/ masked all-zeros), with verify guidance. Placeholders/patterns are configurable per product, not hardcoded.guidewright-review
Evals
capture-scrubs-identifiers— a described flow seeded with a real-shaped email/UUID/workspace name; the authored page must use placeholders and plan the scrub.review-catches-leaked-identifiers— newevals/fixtures/leaky-howto.mdwith planted leaks; review must flag all three.0.2.0.Testing note
guidewright's evals are behavioral (one agent-run per eval, LLM-judged). They were authored in the existing evals.json format and dry-run-validated: the edited skills satisfy every new assertion, and the pre-change skills would fail them (so the evals actually guard the new behavior). Full harness run (spawns per-eval agents) should be run by a non-fork session or CI.
All planted identifiers in fixtures are fictional; no real accounts/orgs/ids appear anywhere in the diff.