Repository navigation
fix(turbosign): return actual backend response from void method - #9
Merged
Merged
Conversation
The void method was ignoring the backend response and returning a
hardcoded { success: true, message: '...' } object. This didn't match
what the backend actually returns.
Changes:
- Updated VoidDocumentResponse type to match backend schema:
{ id, name, status, voidReason, voidedAt }
- Return actual backend response instead of hardcoded object
- Updated JSDoc examples
Note: Requires backend fix (RapidDocxBackend PR #1139) to be deployed
first, as the backend currently returns empty {} due to a separate bug.
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Same bug as JS SDK - all SDKs were ignoring the backend response and
returning hardcoded { success: true, message: '...' } objects.
Changes:
- PHP: Return actual response, update VoidDocumentResponse type
- Python: Return actual response, update docstring
- Go: Return actual response, update VoidDocumentResponse struct
- Java: Return actual response, update VoidDocumentResponse class
All SDKs now return: { id, name, status, voidReason, voidedAt }
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Update all SDK test files to expect the new response format:
{ id, name, status, voidReason, voidedAt }
instead of the old hardcoded:
{ success: true, message: '...' }
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
AmitSharma512
marked this pull request as ready for review
January 27, 2026 13:22
AmitSharma512
approved these changes
Jan 27, 2026
Member
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code |
Member
Author
|
@AmitSharma512 -- todo for me, bump all versions of SDK for publishing |
- JS SDK: 0.1.1 → 0.1.2 - Python SDK: 0.1.0 → 0.1.2 - Java SDK: 1.0.0 → 0.1.2 - Go SDK: uses tags only (no version file) - PHP SDK: uses tags only (no version file in composer.json) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes void method returning empty/hardcoded response in all SDKs:
sign.ts,types/sign.tsTurboSign.php,VoidDocumentResponse.phpsign.pyturbosign.goTurboSign.java,VoidDocumentResponse.javaThe Bug
All SDKs were ignoring the backend response and returning hardcoded objects:
The Fix
Now all SDKs return the actual backend response:
{ "id": "document-uuid", "name": "Document Name", "status": "voided", "voidReason": "Reason provided", "voidedAt": "2026-01-26T19:49:02.000Z" }Dependencies
Test plan
TurboSign.void(documentId, reason)TurboSign::void($documentId, $reason)await TurboSign.void_document(document_id, reason)client.VoidDocument(ctx, documentID, reason)turboSign.voidDocument(documentId, reason){ id, name, status, voidReason, voidedAt }🤖 Generated with Claude Code