Repository navigation
fix(docs): use a placeholder for example webhook secrets - #181
Merged
Merged
Conversation
The Create Webhook and Regenerate Webhook Secret response examples used realistic-looking whsec_ values (TurboDocx format: whsec_ + 64 hex), which secret scanners report as a Stripe webhook secret. Replace them with an obvious placeholder.
1 of 3 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #180
GitGuardian flagged the example
whsec_values on the Create Webhook and Regenerate Webhook Secret pages (added in #171) as a Stripe webhook secret. They are in TurboDocx's own webhook-secret format (70 chars), not Stripe's, and are expected to be invented examples; see #180 for the assessment and the owner's DB confirmation step.Replaces both with
whsec_REPLACE_WITH_YOUR_WEBHOOK_SECRET. 2 files, 2 lines. No other realisticwhsec_values exist in the repo content.Test plan
git grep -E "whsec_[0-9a-f]{32,}"on the branch: 0 matches