Skip to content

Feautre/azpi arte/info display modal#167

Merged
benjaminJohnson2204 merged 6 commits into
mainfrom
Feautre/azpi-arte/info_display_modal
Dec 19, 2025
Merged

Feautre/azpi arte/info display modal#167
benjaminJohnson2204 merged 6 commits into
mainfrom
Feautre/azpi-arte/info_display_modal

Conversation

@azpi-arte

@azpi-arte azpi-arte commented Jun 6, 2025

Copy link
Copy Markdown
Contributor

Tracking Info

Resolves #22

CSS Checklist

  • Do you have width, padding, margin with a high (> ~ 100px) or negative value? Do you need it? Can rem em % vw vh be used instead?
  • Did you avoid hard coding positions? (position, top, left, rules) Can display:flex; and justify and align uses be used instead?

Changes

Added Directory Display Info Modal
Created a supplementary file for contants in Directory Display Info Modal.

Added exit on 'escape' logic
Made profile picture component take string as optional, it is now self contained and can grab the first name from the backend

  • TODO
  • make sure license number adheres to format...I don't know whether there was a specific format in Figma.

Testing

I submitted to the backend using "save" button. I refreshed the page and checked if the form was populated with the correct info

I also changed some of the info, merely closed instead of saving. matched expected behavior.

Tried different country codes and submitted

  • TODO

Confirmation of Change

Screenshot 2025-06-05 204027
Screenshot 2025-06-05 204021
Screenshot 2025-06-05 204017
Screenshot 2025-06-05 203954
Screenshot 2025-06-05 203933

TODO

@azpi-arte azpi-arte requested a review from Miyuki-L as a code owner June 6, 2025 03:43

@benjaminJohnson2204 benjaminJohnson2204 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work hermano 💪

@benjaminJohnson2204 benjaminJohnson2204 merged commit 8a2474e into main Dec 19, 2025
2 checks passed
@benjaminJohnson2204 benjaminJohnson2204 deleted the Feautre/azpi-arte/info_display_modal branch December 19, 2025 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Directory Info Display Modal

2 participants