Kirustar14/manage admin#142
Conversation
Miyuki-L
left a comment
Miyuki-L
left a comment
There was a problem hiding this comment.
Just a few tiny minor changes. Great work !
| Services: string[]; | ||
| }; | ||
|
|
||
| const dummyAdmins: AdminRow[] = [ |
There was a problem hiding this comment.
Can we not just call the backend route you wrote?
Miyuki-L
left a comment
Miyuki-L
left a comment
There was a problem hiding this comment.
Great work some minor details and improvements
| <div style={{ position: "relative" }}> | ||
| <h1 className={styles.title}>Manage Admins</h1> | ||
|
|
||
| <FilterableTable |
There was a problem hiding this comment.
This change here inside main that was merged in the one of the PR's I had you review address this problem https://github.com/TritonSE/SPLAGen-Website/blob/main/frontend/src/app/manageCounselor/page.tsx#L176
Merge main branch in to this branch to deal with it.
Not quite sure why the lint check git hook doesn't catch it but in visual studio it does picks it up
| padding: "0.5rem 0", | ||
| }} | ||
| > | ||
| <input |
There was a problem hiding this comment.
we have a custom checkbox componetns in the components folder.. This will help take care of making the check box match the figma design.
Miyuki-L
left a comment
Miyuki-L
left a comment
There was a problem hiding this comment.
just a few comments from last round still aren't addressed.
Address merge conflicts
| "Rare Diseases", | ||
| "Nuerogenetics", | ||
| "Adult Genetics", | ||
| ], |
There was a problem hiding this comment.
Should we not include languages in the filters?
3 participants
Tracking Info
Resolves #120
CSS Checklist
remem%vwvhbe used instead?display:flex;and justify and align uses be used instead?I did use position absolute and fixed, but I'm not sure how to change it, I tried using display flex but didn't work.
Changes
Testing
visited manage admin page
TODO