Repository navigation
🔁 lore-bin: Re-resolve DNS on every download retry - #48
Merged
Merged
Conversation
curl caches DNS answers for 60 s within a process, so `--retry` reused a lookup that came back with only IPv6 addresses on a runner without IPv6, failing all retries. Start a fresh curl per attempt instead, with 5 attempts backing off 2, 4, 8 and 16 s. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
@patchandpray is this something we should look into on the runners? |
LuukAsmus
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The retries from #47 never help when a DNS lookup goes wrong, and on the self-hosted runners that is the failure we keep hitting. In this Evolve CI job the IPv4 (A) lookup for the mirror timed out and only IPv6 addresses came back, which the runner can't reach:
curl keeps DNS answers for 60 s within one process, and
--retryretries inside that same process. Every one of the 10 retries (50 s in total) took the cached IPv6-only answer and failed in 0 ms.Changes
curlfor each attempt instead of using curl's--retry, so each attempt does a new DNS lookup.--retry-max-time 180.--verbosestays.Evidence
Pointing
downloadat an unresolvable host locally, every attempt runs its own lookup (Could not resolve host) instead of reporting a hit in the DNS cache. A real download on Linux x86_64 still fetches and extracts the library.🤖 Generated with Claude Code