Repository navigation
📛 Allow downloading from mirrors - #46
Merged
Merged
Conversation
A build script that fetches the Lore library from somewhere other than the GitHub release, a mirror of it, say, needs the same two facts `fetch_binary` keeps to itself: the release the bindings are generated for, and the name of the asset holding the library for a target. Both are public now; `fetch_binary` is built on them and unchanged in what it does.
LuukAsmus
force-pushed
the
lore-bin-asset-name
branch
2 times, most recently
from
October 19, 2026 09:14
f1cecf9 to
8a05a7e
Compare
fetch_binary_from takes the URL under which the release assets are found as v<version>/<asset>, named as the GitHub release names them, so a build can depend on storage of its own. fetch_binary is that with GitHub as the mirror.
LuukAsmus
force-pushed
the
lore-bin-asset-name
branch
4 times, most recently
from
October 19, 2026 09:22
d31ddbb to
b9e56fe
Compare
maxded
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
lore_bin::fetch_binarydownloads the Lore library from Epic's GitHub release and only from there. A build that should depend on storage of its own, a mirror of the release, has to reimplement the download, and copy the two facts it rests on: the release the bindings are generated for, and the name of the asset holding the library for a target.Solution
fetch_binary_from(mirror, target)fetches from any URL under which the release assets are found asv<version>/<asset>, named as the GitHub release names them.fetch_binaryis that with GitHub's release host as the mirror, unchanged in what it does.LORE_VERSIONandarchive_name(target)are public, for a consumer that needs to know what will be fetched, to check a mirror holds it, say.Implications