Skip to content

📛 Allow downloading from mirrors - #46

Merged
LuukAsmus merged 2 commits into
mainfrom
lore-bin-asset-name
Oct 19, 2026
Merged

LuukAsmus merged 2 commits into
mainfrom
lore-bin-asset-name

Conversation

@LuukAsmus

@LuukAsmus LuukAsmus commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

lore_bin::fetch_binary downloads the Lore library from Epic's GitHub release and only from there. A build that should depend on storage of its own, a mirror of the release, has to reimplement the download, and copy the two facts it rests on: the release the bindings are generated for, and the name of the asset holding the library for a target.

Solution

  • fetch_binary_from(mirror, target) fetches from any URL under which the release assets are found as v<version>/<asset>, named as the GitHub release names them. fetch_binary is that with GitHub's release host as the mirror, unchanged in what it does.
  • LORE_VERSION and archive_name(target) are public, for a consumer that needs to know what will be fetched, to check a mirror holds it, say.

Implications

  • Where to fetch from stays each consumer's own line; this crate knows only Epic's release and the shape a mirror of it keeps.

A build script that fetches the Lore library from somewhere other than
the GitHub release, a mirror of it, say, needs the same two facts
`fetch_binary` keeps to itself: the release the bindings are generated
for, and the name of the asset holding the library for a target. Both
are public now; `fetch_binary` is built on them and unchanged in what it
does.
@LuukAsmus
LuukAsmus force-pushed the lore-bin-asset-name branch 2 times, most recently from f1cecf9 to 8a05a7e Compare October 19, 2026 09:14
fetch_binary_from takes the URL under which the release assets are found
as v<version>/<asset>, named as the GitHub release names them, so a build
can depend on storage of its own. fetch_binary is that with GitHub as the
mirror.
@LuukAsmus
LuukAsmus force-pushed the lore-bin-asset-name branch 4 times, most recently from d31ddbb to b9e56fe Compare October 19, 2026 09:22
@LuukAsmus LuukAsmus changed the title 📛 lore-bin: Expose the Lore version and the release asset names 📛 Allow downloading from mirrors Oct 19, 2026
@LuukAsmus
LuukAsmus requested a review from maxded October 19, 2026 09:24
@LuukAsmus
LuukAsmus merged commit 5b12576 into main Oct 19, 2026
8 checks passed
@LuukAsmus
LuukAsmus deleted the lore-bin-asset-name branch October 19, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants