Skip to content

d3d12: Include device removal reason when ERROR_DEVICE_REMOVED is raised #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarijnS95 merged 1 commit into from
Jan 30, 2025
Merged

d3d12: Include device removal reason when ERROR_DEVICE_REMOVED is raised #262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion src/d3d12/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,10 @@ use std::{
use log::{debug, warn, Level};
use windows::Win32::{
Foundation::E_OUTOFMEMORY,
Graphics::{Direct3D12::*, Dxgi::Common::DXGI_FORMAT},
Graphics::{
Direct3D12::*,
Dxgi::{Common::DXGI_FORMAT, DXGI_ERROR_DEVICE_REMOVED},
},
};

#[cfg(feature = "public-winapi")]
Expand Down Expand Up @@ -954,6 +957,12 @@ impl Allocator {
}
}
} {
if e.code() == DXGI_ERROR_DEVICE_REMOVED {
return Err(AllocationError::Internal(format!(
"ID3D12Device::CreateCommittedResource DEVICE_REMOVED: {:?}",
unsafe { self.device.GetDeviceRemovedReason() }
)));
}
return Err(AllocationError::Internal(format!(
"ID3D12Device::CreateCommittedResource failed: {}",
e
Expand Down Expand Up @@ -1064,6 +1073,12 @@ impl Allocator {
}
}
} {
if e.code() == DXGI_ERROR_DEVICE_REMOVED {
return Err(AllocationError::Internal(format!(
"ID3D12Device::CreatePlacedResource DEVICE_REMOVED: {:?}",
unsafe { self.device.GetDeviceRemovedReason() }
)));
}
return Err(AllocationError::Internal(format!(
"ID3D12Device::CreatePlacedResource failed: {}",
e
Expand Down