Conversation
Jasper-Bekkers
approved these changes
Jan 24, 2025
MarijnS95
force-pushed
the
objc2-0.6
branch
2 times, most recently
from
1f6478d to
017ee6f
Compare
Jasper-Bekkers
approved these changes
Jan 24, 2025
Member
Author
|
Oh - the MSRV check has been renamed to |
MarijnS95
changed the title
objc2 0.6 and objc2-metal 0.3objc2 0.6 and objc2-metal 0.3
Member
|
Updated the rules, just needs a rebase it seems. |
Member
|
Rebase went fine but it looks like commits aren't signed. |
The `MTLCreateSystemDefaultDevice()` function finally has a high-level wrapper that constructs a `Retained` protocol object for us. Note also that a new `MTLAllocation` interface was added to Metal. Even if that interface is _optional_, current `objc2` design requires this trait to be part of the hierarchy (and the feature explicitly enabled) to get access to all "descendant" interfaces (`MTLResource`, which provides `MTLBuffer` and `MTLTexture`).
Member
Author
|
Hmm seems GitHub no longer signs commits with its own key on rebase (for the better, probably). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
MTLCreateSystemDefaultDevice()function finally has a high-level wrapper that constructs aRetainedprotocol object for us.Note also that a new
MTLAllocationinterface was added to Metal. Even if that interface is optional, currentobjc2design requires this trait to be part of the hierarchy (and the feature explicitly enabled) to get access to all "descendant" interfaces (MTLResource, which providesMTLBufferandMTLTexture). There are upstream plans to see if this can be simplified: madsmtm/objc2#663.