Skip to content

docs: replace stale app.* comments with current package names (SM-118) - #4660

Open
alertxsto wants to merge 4 commits into
Tracer-Cloud:mainfrom
alertxsto:main
Open

docs: replace stale app.* comments with current package names (SM-118)#4660
alertxsto wants to merge 4 commits into
Tracer-Cloud:mainfrom
alertxsto:main

Conversation

@alertxsto

Copy link
Copy Markdown

Fixes #4652

3 occurrences of app.* replaced with core, tools, or surfaces:

  • tests/benchmarks/_framework/types.py: 1 occurrence
  • tests/benchmarks/_framework/adapter_base.py: 2 occurrences

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Greptile code review

This repo uses Greptile for automated review. Before merge, aim for Confidence Score: 5/5 with zero unresolved review threads — see CONTRIBUTING.md.

Run a review — add a PR comment with:

@greptile review

Give it ~5-10 minutes (sometimes longer) for results, then fix feedback and re-trigger until you reach Confidence Score: 5/5.

Optional: automate with the greploop skill.

@greptile-apps

greptile-apps Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Updates benchmark framework documentation to replace stale app.* package references with the current core, tools, and surfaces package names.

  • Clarifies the module-load import boundary in adapter_base.py.
  • Updates the equivalent framework-independence description in types.py.

Confidence Score: 5/5

The PR appears safe to merge because it only corrects stale package names in comments.

The updated comments accurately describe the changed modules’ existing import boundaries, and no executable code or runtime contract is modified.

Important Files Changed

Filename Overview
tests/benchmarks/_framework/adapter_base.py Accurately updates two comments describing runtime and type-only imports without changing behavior.
tests/benchmarks/_framework/types.py Accurately updates the module documentation to use the current package names without changing behavior.

Reviews (1): Last reviewed commit: "docs: replace stale app.* wording with c..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SM-118: Reword stale app.* comments in bench types

2 participants