7 jh refactor - #20
Open
jkhillier wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
7_JH_refactor – Commit #1 - print and ptrdiff_t done in ReadData(). Commit #2 - wavInterpComb() print and ptrdiff_t done. Commit #3 – getlineJH() & Interpolate() changed to ptrdiff_t, PostProcess() removed prints. Commit #4 - PostProcess() Changed int to ptrdiff_t. No more changes needed to Interpolate. Commit #5 - quick_select() and tempInterp not used and removed.
• There are no more functions in wavelet that need checking out.
• fopen() is only in ReadData() - passes file pointer to getlineJH(), in wavInterpCombii() – passes pointer to getlineJH(). In wavelet() and
• fprintf() is in wavelet() only, which opens and closes 6 files.
• getlineJH() and ReadData(); these only read data – so I’m guessing they don’t need an ‘inner’ function. wavInterpCombii() – changed to have an inner function.
This only leaves wavelet() I think ….. how do you suggest I re-factor this, since it’s mainly single commands and fprintf()?