Repository navigation
land kanban 575 - #394
Merged
StevenTCramer merged 8 commits intoNov 13, 2026
Merged
land kanban 575#394StevenTCramer merged 8 commits into
StevenTCramer merged 8 commits into
Conversation
Land-Holder: cramer
Land-Holder: cramer
…r-binding-a-jsonexception-is-a-bind
…(InvalidValue) A JsonException (or NotSupported/InvalidOperation/Format exception) thrown while deserializing an object or array member now becomes a NuruBindError for that member, naming the member and JSON path, instead of crashing the process or surfacing as Faulted through the daemon and McpHost. Task 530. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Task 530. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
StevenTCramer
deleted the
task/530-json-member-binding-a-jsonexception-is-a-bind
branch
November 13, 2026 20:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What changed
source/timewarp-nuru-analyzers/generators/emitters/json-args-emitter.assign.cs: theValueShape.Jsonassign wraps
JsonSerializer.Deserializeintry/catch (Exception) when (NuruBindError.IsJsonMemberFailure(...)), sets__ok = falseand recordsNuruBindError.ForJsonMember(key, pattern, exception). The route pattern is threaded in fromEmitFill(
json-args-emitter.validation.cs). The bind method then returns the failure like any scalar bind error,so
--json-args,TryBind, the daemon and McpHost all report it as a bind error.source/timewarp-nuru/invocation/nuru-bind-error.cs: two public static helpers called by generated code.IsJsonMemberFailureis true forJsonException,NotSupportedException,InvalidOperationExceptionand
FormatException(a typed-ID converter that parses text).ForJsonMemberbuilds anInvalidValueerror:
Error: Invalid value for '<key>' on '<pattern>'. <key>: <json path>: <serializer message without the " Path: … | LineNumber …" suffix>. No stack trace.documentation/user/features/agent-invocation.md: one bullet on JSON-member failures beingInvalidValue.tests/timewarp-nuru-mcphost-tests/mcphost-06-json-member-bind-errors.cs(also in the CImulti-mode assembly). An
[Operation]withIReadOnlyList<JbStep> StepsandJbOptions? Optionscoversan unknown enum name in an array item (
Steps: $[0].Tool), a nested-object type mismatch(
Options: $.Limits.Max) and an unparsable nested Guid (Steps: $[0].Target). It checksTryBind(kind
InvalidValue, key, message, no stack trace), in-process--json-argswith plain errors (exit 1),with
UseProblemRendererForErrors()and with--no-daemon(exit 1,error=Invalid), McpHost in process(
isError,error=Invalid), and forwarded through a realNuruDaemonServerfor McpHost and for the CLIvia
AddServeRoute()(same text as in process). A handler exception stayserror=Faultedover McpHost(local and forwarded) and still escapes the in-process CLI as itself.
Gates
./bin/dev build./bin/dev testganda repo audit--fixfor the advisoryvscode-window-icon; see ## Session)Test plan
Smoke:
Expect: 5 tests pass. Before this change the in-process
--json-argscases crash with an unhandledSystem.Text.Json.JsonException, and McpHost reportserror=Faultedinstead oferror=Invalid.Kanban task 530
Session: Roslynk