fix: quickfix parser breaks on Windows paths with drive letters#178
Open
seesee010 wants to merge 3 commits into
Open
fix: quickfix parser breaks on Windows paths with drive letters#178seesee010 wants to merge 3 commits into
seesee010 wants to merge 3 commits into
Conversation
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Remove stale variable from nil-check in M.parse_line(). The regex was updated to capture col_raw directly, but the guard still referenced (always nil), causing parse_line() to unconditionally return nil and breaking quickfix entirely.
|
I commented an additional repro in issue #155. This pr should fix the problem. |
This was referenced Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #155
The quickfix parser used a greedy
:split which breaks Windows pathscontaining drive letters (e.g.
C:\...). TheC:part was mistakenfor the first separator, causing the filepath to be wrong.
Fix: match numeric line/column fields explicitly so the full path is
preserved regardless of OS.