Conversation
✨ create Category entity with relation to DSL and Data point ✨ create DSL entitry with relation to category
✨ create DataPoint Module ✨ create Category Module
✨add controller for DSL, Categoty
🚨 fix sonar lint issue
✏️ fix type error 🚚 rename files
🚚 rename datasetEntry to DataSetEntries
⚰️ Remove Swagger Documentation
|
Kudos, SonarCloud Quality Gate passed!
|
| host: process.env.DB_HOST, | ||
| port: process.env.DB_PORT as any, | ||
| username: process.env.DB_USERNAME, | ||
| password: process.env.DB_PASSWORD, | ||
| database: process.env.DB_DATABASE, |
There was a problem hiding this comment.
Should we have a pre-screen checking if those variables are available in env? I just dont know what happens if one of those variables is null?
| host: process.env.DB_HOST, | ||
| database: process.env.DB_DATABASE, |
There was a problem hiding this comment.
Same question with one below that what happens if one of those is null?
And I was wondering that we should put all retrieving env variables in 1 module/file or we use it directly in different files?
I think it is easier for us to change if we put them all in one file. Like we want to change variable name in .env file? Also, we may repeat running process.env many times when we scatter them in many files.
On other hand, use them directly is easier and faster to develop.
There was a problem hiding this comment.
I dont think this is a big problem since we can refactor our code quickly later. But I just want to know which one should we chose.
Manage this branch in SquashTest this branch here: https://api-av8tm.squash.io |
3 participants
No description provided.