Normalize API error handling and deduplicate response unwrapping logic#80
Open
daatsuka wants to merge 4 commits into
Open
Normalize API error handling and deduplicate response unwrapping logic#80daatsuka wants to merge 4 commits into
daatsuka wants to merge 4 commits into
Conversation
…d typed responses
…d typed responses
…d typed responses
|
@daatsuka is attempting to deploy a commit to the josephchimebuka's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's the PR description:
This change touches
eslint.config.jsto add a new override block targeting test files (**/*.test.{ts,tsx}and**/__tests__/**/*.{ts,tsx}), turning off the@typescript-eslint/no-explicit-anyrule specifically within that scope. When writing tests for API error normalization, we need to throw arbitrary payloads and malformed responses at the client layer to confirm it handles every shape gracefully — forcing strictanybans in test harnesses just leads to pointless type-casting gymnastics that obscure what the test is actually asserting. Relaxing this single rule for test files lets us write honest, readable specs without weakening type safety in production code.The
package-lock.jsonupdate is a straightforwardnpm installresolution bump —@babel/helpersmoved to 7.29.2,@babel/parserto 7.29.2,@babel/runtimeto 7.29.2, and several@esbuildplatform binaries to 0.27.4. Nothing was manually pinned or overridden; this is just the lockfile catching up to the latest compatible ranges already declared inpackage.json. I rannpm cilocally after regenerating the lockfile and confirmed a clean install with zero peer-dependency warnings, then ran the full lint and test suite to make sure nothing regressed with the updated toolchain or the new ESLint override.Closes #74