feat: 新增字画布节点 --story=135278474 - #277
Conversation
| [tool.poetry] | ||
| name = "bamboo-engine" | ||
| version = "2.11.3" | ||
| version = "2.11.4" |
There was a problem hiding this comment.
bamboo_engine/version.py没有改
| [tool.poetry] | ||
| name = "bamboo-pipeline" | ||
| version = "3.29.9" | ||
| version = "3.30.0" |
| return PE.SubProcess | ||
|
|
||
|
|
||
| class SubCanvas(Element): |
There was a problem hiding this comment.
如果在引擎侧抽象了SubCanvas这个概念,建议相关的方法都在引擎侧实现,然后bkflow调用,否则对于bamboo-engine而言,功能上就不是闭环的了,需要耦合bkflow的逻辑才能解析SubCanvas。
或者另一个改法是:SubCanvas这个概念只放到bkflow里,不在bamboo-engine里抽象这个概念
参考:
bamboo-engine/runtime/bamboo-pipeline/pipeline/builder/builder.py
Lines 35 to 58 in 45c2e44
bamboo-engine/runtime/bamboo-pipeline/pipeline/parser/pipeline_parser.py
Lines 142 to 185 in 45c2e44
|
|
||
|
|
||
| @register_handler(NodeType.SubCanvas) | ||
| class SubCanvasHandler(NodeHandler): |
There was a problem hiding this comment.
这里没有把handler注册进去吧
| return NodeType.SubProcess.value | ||
|
|
||
|
|
||
| class SubCanvas(Element): |
There was a problem hiding this comment.
bamboo-engine/runtime/bamboo-pipeline/pipeline/models.py
Lines 233 to 270 in 6e5e357
在对流程进行unfold的时候,有一个替换节点id的操作,可能要看下是否要考虑子画布里的节点
| from pipeline.core.flow.activity.base import Activity | ||
|
|
||
|
|
||
| class SubCanvas(Activity): |
There was a problem hiding this comment.
bamboo-engine/bamboo_engine/api.py
Lines 640 to 662 in 6e5e357
关于这个处理函数,得看下逻辑上是否兼容
No description provided.